Don't write URLs to clipboard from views omnibox as hyperlinks

chrome/browser/bookmarks/bookmark_node_data.cc

Index: chrome/browser/bookmarks/bookmark_node_data.cc
diff --git a/chrome/browser/bookmarks/bookmark_node_data.cc b/chrome/browser/bookmarks/bookmark_node_data.cc
index b1d201fa709f01562dcfae409646c967ef29a49f..0bad59832ee36d925072e74724fe146462bd89b6 100644
--- a/chrome/browser/bookmarks/bookmark_node_data.cc
+++ b/chrome/browser/bookmarks/bookmark_node_data.cc
@@ -143,7 +143,12 @@ void BookmarkNodeData::WriteToClipboard() const {
     const std::string url = elements[0].url.spec();
 
     scw.WriteBookmark(title, url);
+#if !defined(OS_WIN)

[Peter Kasting, 2013/10/05 00:42:27]

This makes me wonder if we should also avoid writing this format on other
platforms.  If the problem is e.g. the gmail text editor, isn't that a
cross-platform problem?  I feel like OS_WIN is probably wrong here.

[scottmg, 2013/10/07 22:16:27]

I confirmed that the behaviour is same (font-preserving) on CrOS, so yes, it
seems reasonable to me not to do this on CrOS & Linux too. Done.

+    // http://crbug.com/976. We don't want hyperlink formatted text on Windows
+    // as that carries font information which can be annoying to remove when
+    // pasting into other programs.

[Peter Kasting, 2013/10/05 00:42:27]

Nit: I generally try to avoid bug links, since they can be confusing to find the
relevant information.  How about:

On Windows, we avoid writing hyperlink data, since some rich text editors will
change fonts when such data is pasted in; besides, most such editors
auto-linkify at some point anyway.

[scottmg, 2013/10/07 22:16:27]

Done.

     scw.WriteHyperlink(title, url);
+#endif
 
     // Also write the URL to the clipboard as text so that it can be pasted
     // into text fields. We use WriteText instead of WriteURL because we don't