Don't write URLs to clipboard from views omnibox as hyperlinks

chrome/browser/bookmarks/bookmark_node_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_node_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/pickle.h"
@@ skipping 125 matching lines @@
   ui::ScopedClipboardWriter scw(ui::Clipboard::GetForCurrentThread(),
                                 ui::Clipboard::BUFFER_STANDARD);
 
   // If there is only one element and it is a URL, write the URL to the
   // clipboard.
   if (elements.size() == 1 && elements[0].is_url) {
     const string16& title = elements[0].title;
     const std::string url = elements[0].url.spec();
 
     scw.WriteBookmark(title, url);
+#if !defined(OS_WIN)

[Peter Kasting, 2013/10/05 00:42:27]

This makes me wonder if we should also avoid writing this format on other
platforms.  If the problem is e.g. the gmail text editor, isn't that a
cross-platform problem?  I feel like OS_WIN is probably wrong here.

[scottmg, 2013/10/07 22:16:27]

I confirmed that the behaviour is same (font-preserving) on CrOS, so yes, it
seems reasonable to me not to do this on CrOS & Linux too. Done.

+    // http://crbug.com/976. We don't want hyperlink formatted text on Windows
+    // as that carries font information which can be annoying to remove when
+    // pasting into other programs.

[Peter Kasting, 2013/10/05 00:42:27]

Nit: I generally try to avoid bug links, since they can be confusing to find the
relevant information.  How about:

On Windows, we avoid writing hyperlink data, since some rich text editors will
change fonts when such data is pasted in; besides, most such editors
auto-linkify at some point anyway.

[scottmg, 2013/10/07 22:16:27]

Done.

     scw.WriteHyperlink(title, url);
+#endif
 
     // Also write the URL to the clipboard as text so that it can be pasted
     // into text fields. We use WriteText instead of WriteURL because we don't
     // want to clobber the X clipboard when the user copies out of the omnibox
     // on Linux (on Windows and Mac, there is no difference between these
     // functions).
     scw.WriteText(UTF8ToUTF16(url));
   }
 
   Pickle pickle;
@@ skipping 92 matching lines @@
   DCHECK(profile_path_.empty());
 
   if (profile)
     profile_path_ = profile->GetPath();
 }
 
 bool BookmarkNodeData::IsFromProfile(Profile* profile) const {
   // An empty path means the data is not associated with any profile.
   return !profile_path_.empty() && profile_path_ == profile->GetPath();
 }