Fix use-after-scope issues in HttpNetworkTransactionTest.

Fix use-after-scope issues in HttpNetworkTransactionTest.

Network transaction keeps a reference to the request and accesses it
from the destructor. That adds a requirement that the life scope of
request must be wider than the scope of transaction. This CL fixes
the cases where it was not true.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
Committed: https://crrev.com/c06a72a8cb9d22ed8606f1a48ec881aeeb1f7891
Cr-Commit-Position: refs/heads/master@{#440000}

[krasin1, 2016-12-21 01:18:39]

krasin@chromium.org changed reviewers:
+ eroman@chromium.org

[krasin1, 2016-12-21 01:18:45]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 01:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-12-21 01:27:05]

LGTM, good find!

[commit-bot: I haz the power, 2016-12-21 01:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:44:52]

Dry run: This issue passed the CQ dry run.

[krasin1, 2016-12-21 03:38:16]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:42:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482291496149650, "parent_rev":
"b1fd2e8b1aa1af9be066a153d09f338ad0d0f65a", "commit_rev":
"f7c590c2738cc6cdae8aaf1b928a4becea288d8e"}

[commit-bot: I haz the power, 2016-12-21 03:43:13]

Description was changed from

==========
Fix use-after-scope issues in HttpNetworkTransactionTest.

Network transaction keeps a reference to the request and accesses it
from the destructor. That adds a requirement that the life scope of
request must be wider than the scope of transaction. This CL fixes
the cases where it was not true.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
==========

to

==========
Fix use-after-scope issues in HttpNetworkTransactionTest.

Network transaction keeps a reference to the request and accesses it
from the destructor. That adds a requirement that the life scope of
request must be wider than the scope of transaction. This CL fixes
the cases where it was not true.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Review-Url: https://codereview.chromium.org/2589363002
==========

[commit-bot: I haz the power, 2016-12-21 03:43:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 03:45:12]

Description was changed from

==========
Fix use-after-scope issues in HttpNetworkTransactionTest.

Network transaction keeps a reference to the request and accesses it
from the destructor. That adds a requirement that the life scope of
request must be wider than the scope of transaction. This CL fixes
the cases where it was not true.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Review-Url: https://codereview.chromium.org/2589363002
==========

to

==========
Fix use-after-scope issues in HttpNetworkTransactionTest.

Network transaction keeps a reference to the request and accesses it
from the destructor. That adds a requirement that the life scope of
request must be wider than the scope of transaction. This CL fixes
the cases where it was not true.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Committed: https://crrev.com/c06a72a8cb9d22ed8606f1a48ec881aeeb1f7891
Cr-Commit-Position: refs/heads/master@{#440000}
==========

[commit-bot: I haz the power, 2016-12-21 03:45:13]

Patchset 1 (id:??) landed as
https://crrev.com/c06a72a8cb9d22ed8606f1a48ec881aeeb1f7891
Cr-Commit-Position: refs/heads/master@{#440000}