Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2589283002:
[WASM] Skip failing F32x4 tests on ARM. (Closed)
Description[WASM] Skip failing F32x4 tests on ARM.
LOG=N
BUG=v8:4124
Review-Url: https://codereview.chromium.org/2589283002
Cr-Commit-Position: refs/heads/master@{#41925}
Committed: https://chromium.googlesource.com/v8/v8/+/0f12793f69992c122f8ef06b670d089230e03a41
Patch Set 1 #
Total comments: 3
Messages
Total messages: 28 (11 generated)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bbudge@chromium.org changed reviewers: + machenbach@chromium.org
bbudge@chromium.org changed reviewers: + machenbach@chromium.org
These fail on actual ARM hardware. It may be a while before I can fix these, so skipping tests for Float32x4 Add / Sub for now.
These fail on actual ARM hardware. It may be a while before I can fix these, so skipping tests for Float32x4 Add / Sub for now.
bbudge@chromium.org changed reviewers: + hablich@chromium.org
+Michael as machenbach is OOO
Example failing bot run: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug/bu...
My theory on these failures is that Neon FP denormals behave differently than VFP. Only FP arithmetic operations are failing.
On 2016/12/20 17:40:50, bbudge_ooo_until_mid_jan wrote: > My theory on these failures is that Neon FP denormals behave differently than > VFP. Only FP arithmetic operations are failing. Neon FP flush denorm to zero, for VFP it is configurable but usually it is setup to follow IEE 7XX
On 2016/12/20 17:40:50, bbudge_ooo_until_mid_jan wrote: > My theory on these failures is that Neon FP denormals behave differently than > VFP. Only FP arithmetic operations are failing. Neon FP flush denorm to zero, for VFP it is configurable but usually it is setup to follow IEE 7XX
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
See this speculative fix. We may not need to skip the tests. https://codereview.chromium.org/2598583002/
lgtm
On 2016/12/21 10:01:08, Hablich wrote: > lgtm Thanks, I'll wait to commit until my fix works through a bot run. If that doesn't turn the bot green, I'll have to add two more tests that are also failing to this skip list.
On 2016/12/21 10:01:08, Hablich wrote: > lgtm My speculative fix got the FP comparision tests to pass. I have another CL to address the still failing arithmetic tests. https://codereview.chromium.org/2594043002/
On 2016/12/21 19:11:01, bbudge_ooo_until_mid_jan wrote: > On 2016/12/21 10:01:08, Hablich wrote: > > lgtm > > My speculative fix got the FP comparision tests to pass. I have another CL > to address the still failing arithmetic tests. > > https://codereview.chromium.org/2594043002/ I have another speculative CL to fix this, but no one is around for review so I will land this one which should green the bot.
The CQ bit was checked by bbudge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482421230001980, "parent_rev":
"73036fb6916e5b2d75db766d695ae7a45af138a4", "commit_rev":
"0f12793f69992c122f8ef06b670d089230e03a41"}
Message was sent while issue was closed.
Description was changed from ========== [WASM] Skip failing F32x4 tests on ARM. LOG=N BUG=v8:4124 ========== to ========== [WASM] Skip failing F32x4 tests on ARM. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2589283002 Cr-Commit-Position: refs/heads/master@{#41925} Committed: https://chromium.googlesource.com/v8/v8/+/0f12793f69992c122f8ef06b670d089230e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/0f12793f69992c122f8ef06b670d089230e...
Message was sent while issue was closed.
lgtm https://codereview.chromium.org/2589283002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/2589283002/diff/1/test/cctest/cctest.status#n... test/cctest/cctest.status:216: # BUG(1075): Unresolved crashes. Note, the CL is linked to bug 4124.
Message was sent while issue was closed.
bbudge@google.com changed reviewers: + bbudge@google.com
Message was sent while issue was closed.
https://codereview.chromium.org/2589283002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/2589283002/diff/1/test/cctest/cctest.status#n... test/cctest/cctest.status:216: # BUG(1075): Unresolved crashes. On 2016/12/23 19:01:51, Michael Achenbach (OOO) wrote: > Note, the CL is linked to bug 4124. Do you want me to add a comment here? I have a CL that may fix these failures, and removes the SKIPs here. It's awaiting a review by a src/compiler OWNER. https://codereview.chromium.org/2594043002/
Message was sent while issue was closed.
https://codereview.chromium.org/2589283002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/2589283002/diff/1/test/cctest/cctest.status#n... test/cctest/cctest.status:216: # BUG(1075): Unresolved crashes. On 2016/12/23 19:29:13, bbudge-google wrote: > On 2016/12/23 19:01:51, Michael Achenbach (OOO) wrote: > > Note, the CL is linked to bug 4124. > > Do you want me to add a comment here? I have a CL that may fix these failures, > and removes the SKIPs here. It's awaiting a review by a src/compiler OWNER. > > https://codereview.chromium.org/2594043002/ nah, never mind. just please keep an overview yourself... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
