CSP: fix bugs in parseHost (+ add unit test)

CSP: fix bugs in parseHost (+ add unit test)

The problem was that host like : "*."  or "sub.host." were
validated by SourceListDirective::parseHost, while they aren't valid.

BUG=676260
Committed: https://crrev.com/4bd219e45f7ba50880725bc55e94aa13359c3cd9
Cr-Commit-Position: refs/heads/master@{#440378}

[arthursonzogni, 2016-12-21 09:40:19]

The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 09:40:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 11:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 11:48:12]

Dry run: This issue passed the CQ dry run.

[arthursonzogni, 2016-12-21 13:31:16]

arthursonzogni@chromium.org changed reviewers:
+ sigbjornf@opera.com

[arthursonzogni, 2016-12-21 13:31:17]

Hi @sigbjornf,

Please. Do you think you can review this CL? Thanks!

@mkwst: FYI.

[sof, 2016-12-21 21:43:35]

lgtm

mkwst@ would be the better person to handle it, but he appears out. The change
is fine though, simpler logic.

https://codereview.chromium.org/2589273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2589273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:1345: {"*",
TRUE},
Could you downcase (TRUE, FALSE) to (true, false) ? It appears to be the local
style.

[Mike West, 2016-12-22 07:27:42]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-12-22 07:27:43]

I am OOO, but I accidentally saw this anyway. LGTM. :)

https://codereview.chromium.org/2589273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2589273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:1345: {"*",
TRUE},
On 2016/12/21 at 21:43:35, sof wrote:
> Could you downcase (TRUE, FALSE) to (true, false) ? It appears to be the local
style.

I hope it's not just local style;
https://google.github.io/styleguide/cppguide.html and
https://sites.google.com/a/chromium.org/dev/blink/coding-style both spell
boolean constants in lowercase.

[arthursonzogni, 2016-12-22 09:13:45]

Thanks!

https://codereview.chromium.org/2589273003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2589273003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:1345: {"*",
TRUE},
On 2016/12/22 07:27:42, Mike West (OOO until the 9th) wrote:
> On 2016/12/21 at 21:43:35, sof wrote:
> > Could you downcase (TRUE, FALSE) to (true, false) ? It appears to be the
local
> style.
> 
> I hope it's not just local style;
> https://google.github.io/styleguide/cppguide.html and
> https://sites.google.com/a/chromium.org/dev/blink/coding-style both spell
> boolean constants in lowercase.

Oops, I did not even know that {TRUE, FALSE} was defined. It's strange to me
that I wrote this. Maybe I failed my vim macro from EXPECT_TRUE(...)
EXPECT_FALSE(...).

[arthursonzogni, 2016-12-22 09:14:48]

The CQ bit was checked by arthursonzogni@chromium.org

[arthursonzogni, 2016-12-22 09:14:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2589273003/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-12-22 09:15:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 10:44:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482398088291110,
"parent_rev": "1a825c935a83a2eee0aec6f43c4d896ed7ceaeeb", "commit_rev":
"24f45ac60440a1b560f954facab4bc94d475f966"}

[commit-bot: I haz the power, 2016-12-22 10:45:02]

Description was changed from

==========
CSP: fix bugs in parseHost (+ add unit test)

The problem was that host like : "*."  or "sub.host." were
validated by SourceListDirective::parseHost, while they aren't valid.

BUG=676260
==========

to

==========
CSP: fix bugs in parseHost (+ add unit test)

The problem was that host like : "*."  or "sub.host." were
validated by SourceListDirective::parseHost, while they aren't valid.

BUG=676260

Review-Url: https://codereview.chromium.org/2589273003
==========

[commit-bot: I haz the power, 2016-12-22 10:45:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-22 10:47:55]

Description was changed from

==========
CSP: fix bugs in parseHost (+ add unit test)

The problem was that host like : "*."  or "sub.host." were
validated by SourceListDirective::parseHost, while they aren't valid.

BUG=676260

Review-Url: https://codereview.chromium.org/2589273003
==========

to

==========
CSP: fix bugs in parseHost (+ add unit test)

The problem was that host like : "*."  or "sub.host." were
validated by SourceListDirective::parseHost, while they aren't valid.

BUG=676260

Committed: https://crrev.com/4bd219e45f7ba50880725bc55e94aa13359c3cd9
Cr-Commit-Position: refs/heads/master@{#440378}
==========

[commit-bot: I haz the power, 2016-12-22 10:47:56]

Patchset 3 (id:??) landed as
https://crrev.com/4bd219e45f7ba50880725bc55e94aa13359c3cd9
Cr-Commit-Position: refs/heads/master@{#440378}