Remove discardable_memory::DSMM::{Create,Get}Instance()

Remove discardable_memory::DSMM::{Create,Get}Instance()

BUG=654678
Committed: https://crrev.com/cf8239721f203649aa6c309502e74863e6d84085
Cr-Commit-Position: refs/heads/master@{#440113}

[Peng, 2016-12-20 16:07:32]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 16:07:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peng, 2016-12-20 16:26:22]

penghuang@chromium.org changed reviewers:
+ reveman@chromium.org

[Peng, 2016-12-20 16:26:22]

Hi David, PTAL. Thanks.

[reveman, 2016-12-20 16:36:54]

lgtm

[Peng, 2016-12-20 16:42:45]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 16:43:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peng, 2016-12-20 16:43:59]

penghuang@chromium.org changed reviewers:
+ avi@chromium.org

[Peng, 2016-12-20 16:44:00]

+avi for content

Hi Avi, PTAL. Thanks.

[Peng, 2016-12-20 16:45:14]

penghuang@chromium.org changed reviewers:
+ msw@chromium.org

[Peng, 2016-12-20 16:45:15]

+ msw@ for //services/ui

Hi Mike, PTAL. Thanks.

[msw, 2016-12-20 16:53:30]

rubber stamp lgtm with a minor comment

https://codereview.chromium.org/2589253002/diff/60001/services/ui/service.h
File services/ui/service.h (right):

https://codereview.chromium.org/2589253002/diff/60001/services/ui/service.h#n...
services/ui/service.h:45: namespace discardable_memory {
Remove this; the include should suffice.

[Avi (use Gerrit), 2016-12-20 17:10:41]

lgtm

[commit-bot: I haz the power, 2016-12-20 17:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 17:37:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-12-20 18:34:40]

https://codereview.chromium.org/2589253002/diff/60001/services/ui/service.h
File services/ui/service.h (right):

https://codereview.chromium.org/2589253002/diff/60001/services/ui/service.h#n...
services/ui/service.h:45: namespace discardable_memory {
On 2016/12/20 16:53:29, msw wrote:
> Remove this; the include should suffice.

I just found out the discardable memory manager cannot be created in ctro, it
has to be in OnStart(). So I removed the include and change the manager member
to pointer.

[Peng, 2016-12-20 18:34:56]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-12-20 18:34:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, msw@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2589253002/#ps80001
(title: "Fix trybot")

[commit-bot: I haz the power, 2016-12-20 18:35:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 21:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 21:30:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-12-21 14:51:03]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:51:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:01:16]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482331863837290,
"parent_rev": "d4d5a24405cd67e579d889b2727afd678592f826", "commit_rev":
"5fcdb72b4971d4536529ab8fd8b24e1008d93432"}

[commit-bot: I haz the power, 2016-12-21 16:03:19]

Description was changed from

==========
Remove discardable_memory::DSMM::{Create,Get}Instance()

BUG=654678
==========

to

==========
Remove discardable_memory::DSMM::{Create,Get}Instance()

BUG=654678

Review-Url: https://codereview.chromium.org/2589253002
Committed:
https://chromium.googlesource.com/chromium/src/+/5fcdb72b4971d4536529ab8fd8b2...
==========

[commit-bot: I haz the power, 2016-12-21 16:03:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5fcdb72b4971d4536529ab8fd8b2...

[commit-bot: I haz the power, 2016-12-21 16:03:46]

Description was changed from

==========
Remove discardable_memory::DSMM::{Create,Get}Instance()

BUG=654678

Review-Url: https://codereview.chromium.org/2589253002
Committed:
https://chromium.googlesource.com/chromium/src/+/5fcdb72b4971d4536529ab8fd8b2...
==========

to

==========
Remove discardable_memory::DSMM::{Create,Get}Instance()

BUG=654678

Committed: https://crrev.com/cf8239721f203649aa6c309502e74863e6d84085
Cr-Commit-Position: refs/heads/master@{#440113}
==========

[commit-bot: I haz the power, 2016-12-21 16:03:47]

Patchset 5 (id:??) landed as
https://crrev.com/cf8239721f203649aa6c309502e74863e6d84085
Cr-Commit-Position: refs/heads/master@{#440113}