Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2589193002: Revert to the old back arrow style with NavigationBar (Closed)

Created:
4 years ago by lpromero
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert to the old back arrow style with NavigationBar MDC has a method to use the old style, but it's in a private component and the wind is blowing towards removing it at some point, so this CL just opt-s out of MDC driving the back button in Settings. I still filed a request at MDC to have the method public, but it might never come, or they might remove the old style before that. BUG=none R=sdefresne@chromium.org Committed: https://crrev.com/66b3060d0e1b646a1a09ec1b7f26358ab71fddf8 Cr-Commit-Position: refs/heads/master@{#439776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M ios/chrome/browser/ui/settings/autofill_settings_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/block_popups_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_navigation_controller.mm View 4 chunks +23 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/translate_ui_egtest.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
lpromero
4 years ago (2016-12-20 12:08:00 UTC) #1
sdefresne
lgtm
4 years ago (2016-12-20 12:13:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589193002/1
4 years ago (2016-12-20 12:32:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 12:36:21 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 12:38:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66b3060d0e1b646a1a09ec1b7f26358ab71fddf8
Cr-Commit-Position: refs/heads/master@{#439776}

Powered by Google App Engine
This is Rietveld 408576698