Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)
Patch Set: Capitalize the prefix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl
index 7e17d48d79379031c015879be4833a597a0fdcd3..431a46279bbe0423129467d4da34ca62d70cace3 100644
--- a/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl
@@ -11,7 +11,7 @@ namespace blink {
InternalSettingsGenerated::InternalSettingsGenerated(Page* page)
: m_page(page)
{% for setting in settings if setting.type|to_idl_type %}
- , m_{{setting.name}}(page->settings().{{setting.name}}())
+ , m_{{setting.name}}(page->settings().Get{{setting.name|upper_first}}())
Łukasz Anforowicz 2016/12/21 21:07:36 |upper_first| causes ...FEtch... issue. I wonder
nasko 2017/01/04 18:18:51 Done.
{% endfor %}
{
}

Powered by Google App Engine
This is Rietveld 408576698