Add 'get' prefix for Settings.in generated code.

third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl

 {% from "macros.tmpl" import license %}
 {{ license() }}
 
 #include "InternalSettingsGenerated.h"
 
 #include "core/page/Page.h"
 #include "core/frame/Settings.h"
 
 namespace blink {
 
 InternalSettingsGenerated::InternalSettingsGenerated(Page* page)
     : m_page(page)
     {% for setting in settings if setting.type|to_idl_type %}
-    , m_{{setting.name}}(page->settings().{{setting.name}}())
+    , m_{{setting.name}}(page->settings().Get{{setting.name|upper_first}}())

[Łukasz Anforowicz, 2016/12/21 21:07:36]

|upper_first| causes ...FEtch... issue.  I wonder if we should switch to
|upper_first_letter| or tweak implementation of |upper_first| so that it checks
what is *after* the acronym:

# not tested / pseudocode / I don't know if len(...) and is_upper_case are a
thing in Python:
def upper_first(name):
    """Return name with first letter or initial acronym uppercased."""
    for acronym in ACRONYMS:
-        if name.startswith(acronym.lower()):
+        if name.startswith(acronym.lower()) and len(name) > len(acronym) and
is_upper_case(name[len(acronym)]):
            return name.replace(acronym.lower(), acronym, 1)
    return upper_first_letter(name)

[nasko, 2017/01/04 18:18:51]

Done.

     {% endfor %}
 {
 }
 
 InternalSettingsGenerated::~InternalSettingsGenerated() {}
 
 void InternalSettingsGenerated::resetToConsistentState() {
   {% for setting in settings if setting.type|to_idl_type %}
   m_page->settings().set{{setting.name|upper_first}}(m_{{setting.name}});
   {% endfor %}
 }
 {% for setting in settings if setting.type|to_idl_type %}
 
 void InternalSettingsGenerated::set{{setting.name|upper_first}}({{setting.type|to_passing_type}} {{setting.name}}) {
   m_page->settings().set{{setting.name|upper_first}}({{setting.name}});
 }
 {% endfor %}
 
 DEFINE_TRACE(InternalSettingsGenerated) {
   visitor->trace(m_page);
 }
 
 } // namespace blink