Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 25891004: Build cast_unittest (Closed)

Created:
7 years, 2 months ago by Alpha Left Google
Modified:
7 years, 2 months ago
Reviewers:
tapted, justinlin
CC:
chromium-reviews, tapted
Visibility:
Public.

Description

Build cast_unittest Build cast targets on all bots. R=justinlin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alpha Left Google
7 years, 2 months ago (2013-10-03 20:54:00 UTC) #1
justinlin
lgtm
7 years, 2 months ago (2013-10-03 20:55:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/25891004/1
7 years, 2 months ago (2013-10-03 20:59:13 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-03 21:04:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/25891004/1
7 years, 2 months ago (2013-10-03 22:04:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/25891004/1
7 years, 2 months ago (2013-10-03 23:56:07 UTC) #6
Alpha Left Google
Committed patchset #1 manually as r226914 (presubmit successful).
7 years, 2 months ago (2013-10-04 00:57:48 UTC) #7
tapted
On 2013/10/04 00:57:48, Alpha wrote: > Committed patchset #1 manually as r226914 (presubmit successful). Reverted ...
7 years, 2 months ago (2013-10-04 04:45:14 UTC) #8
Alpha Left Google
On 2013/10/04 04:45:14, tapted wrote: > On 2013/10/04 00:57:48, Alpha wrote: > > Committed patchset ...
7 years, 2 months ago (2013-10-04 17:17:20 UTC) #9
tapted
7 years, 2 months ago (2013-10-08 05:45:59 UTC) #10
Message was sent while issue was closed.
On 2013/10/04 17:17:20, Alpha wrote:
> On 2013/10/04 04:45:14, tapted wrote:
> > On 2013/10/04 00:57:48, Alpha wrote:
> > > Committed patchset #1 manually as r226914 (presubmit successful).
> > 
> > Reverted in r226960 (sorry!). This seems to be the cause of CQ failures for
> > others: E.g.
> > 
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/90601/step...
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/win_x64_rel/builds/42...
> > 
> > Revert CL is https://codereview.chromium.org/25368003
> 
> This is unfortunate, how come the same change went through compilation on CQ
and
> then it failed in a later pass!? In particularly the code hasn't changed at
all
> but it compiled fine yesterday and not today, what went wrong?

Comparing outputs... the jobs here compiled fewer files. E.g.

ninja -C /Volumes/data/b/build/slave/mac/build/src/out/Debug
chromium_builder_tests All -j50
ninja: Entering directory `/Volumes/data/b/build/slave/mac/build/src/out/Debug'
[1/9865] CC
obj/native_client/src/trusted/service_runtime/arch/x86_32/service_runtime_x86_32.nacl_app_32.o

vs

ninja -C /Volumes/data/b/build/slave/mac/build/src/out/Debug
chromium_builder_tests All -j50
ninja: Entering directory `/Volumes/data/b/build/slave/mac/build/src/out/Debug'
[1/20055] CXX
obj/third_party/webrtc/system_wrappers/source/system_wrappers.atomic32_mac.o


Perhaps try running jobs via `git cl try --clobber` before hitting up the CQ.

However, this might also point to a missing dependency in gyp, which could
become a problem later..

Powered by Google App Engine
This is Rietveld 408576698