Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 25368003: Revert 226914 "Build cast_unittest" (Closed)

Created:
7 years, 2 months ago by tapted
Modified:
7 years, 2 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 226914 "Build cast_unittest" This seems to be preventing things landing through the CQ due to compile warnings on mac using clang, and on win-64. Error such as FAILED: ninja .. ..\..\media\cast\framer\cast_message_builder_unittest.cc ... error C2220: warning treated as error - no 'object' file generated warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data FAILED: clang++ ... -c ../../media/cast/audio_receiver/audio_receiver.cc -o obj/media/cast/audio_receiver/cast_audio_receiver.audio_receiver.o In file included from ../../media/cast/audio_receiver/audio_receiver.cc:5: ../../media/cast/audio_receiver/audio_receiver.h:117:55:error: no newline at end of file [-Werror,-Wnewline-eof] #endif // MEDIA_CAST_AUDIO_RECEIVER_AUDIO_RECEIVER_H_ > Build cast_unittest > > Build cast targets on all bots. > > R=justinlin@chromium.org > > Review URL: https://codereview.chromium.org/25891004 TBR=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M trunk/src/build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
7 years, 2 months ago (2013-10-04 04:40:17 UTC) #1
tapted
7 years, 2 months ago (2013-10-04 04:40:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r226960.

Powered by Google App Engine
This is Rietveld 408576698