Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2589083002: [debugger] sunset --expose-debug-as flag. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] sunset --expose-debug-as flag. R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2589083002 Cr-Commit-Position: refs/heads/master@{#41832} Committed: https://chromium.googlesource.com/v8/v8/+/a141898108df9b01d524c57d15dea6a1220f31e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -37 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +14 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Yang
4 years ago (2016-12-20 06:05:16 UTC) #1
jgruber
😍 lgtm
4 years ago (2016-12-20 07:43:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589083002/1
4 years ago (2016-12-20 07:44:15 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 07:45:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a141898108df9b01d524c57d15dea6a1220...

Powered by Google App Engine
This is Rietveld 408576698