Split paint property update tests out of PaintPropertyTreeBuilderTest

Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bc41eea2096c3353d589c4325feba9e150742e1e
Cr-Commit-Position: refs/heads/master@{#439712}

[pdr., 2016-12-20 00:50:44]

Description was changed from

==========
Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
==========

to

==========
Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-12-20 00:54:09]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org, wkorman@chromium.org

[pdr., 2016-12-20 00:54:11]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-12-20 00:54:14]

The CQ bit was unchecked by pdr@chromium.org

[pdr., 2016-12-20 00:55:32]

With this patch, our test files have shrunk by -39 lines.

[wkorman, 2016-12-20 01:01:15]

lgtm

https://codereview.chromium.org/2589003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.h
(right):

https://codereview.chromium.org/2589003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.h:37: void
SetUp() override {
Put impl for this and TearDown in .cpp?

[pdr., 2016-12-20 02:56:00]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-12-20 02:56:00]

https://codereview.chromium.org/2589003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.h
(right):

https://codereview.chromium.org/2589003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.h:37: void
SetUp() override {
On 2016/12/20 at 01:01:15, wkorman wrote:
> Put impl for this and TearDown in .cpp?

Good idea, done.

[pdr., 2016-12-20 02:56:01]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2589003002/#ps40001
(title: "Rebase, minor cleanup")

[commit-bot: I haz the power, 2016-12-20 02:56:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482202560339320,
"parent_rev": "b131e52999961f4533914dc7d8031e0954ae6a3e", "commit_rev":
"cc4139c3db0db3c8d0e02232a64d697a08d0b753"}

[commit-bot: I haz the power, 2016-12-20 04:57:22]

Description was changed from

==========
Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2589003002
==========

[commit-bot: I haz the power, 2016-12-20 04:57:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 05:00:32]

Description was changed from

==========
Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2589003002
==========

to

==========
Split paint property update tests out of PaintPropertyTreeBuilderTest

PaintPropertyTreeBuilderTest is over 3.5k lines long which is becoming
unwieldy. This patch splits out the incremental update tests.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bc41eea2096c3353d589c4325feba9e150742e1e
Cr-Commit-Position: refs/heads/master@{#439712}
==========

[commit-bot: I haz the power, 2016-12-20 05:00:33]

Patchset 3 (id:??) landed as
https://crrev.com/bc41eea2096c3353d589c4325feba9e150742e1e
Cr-Commit-Position: refs/heads/master@{#439712}