Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2588983002: Mark readable stream closed promise as handled (Closed)

Created:
4 years ago by domenic
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark readable stream closed promise as handled This matches the spec update at https://github.com/whatwg/streams/commit/0745219ca7b7f02ef104145b78ebebd99c0fd12c for readable streams. The remaining work for writable streams will be performed as part of https://bugs.chromium.org/p/chromium/issues/detail?id=671958. BUG=654701 TEST=will be tested by the updated expectations in https://codereview.chromium.org/2500133002 Committed: https://crrev.com/88ec71ef1d62b1719e0e7dc35e18ae21e02d2f8c Cr-Commit-Position: refs/heads/master@{#440101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/streams/ReadableStream.js View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
domenic
4 years ago (2016-12-20 00:12:06 UTC) #2
yhirano
lgtm
4 years ago (2016-12-20 06:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588983002/1
4 years ago (2016-12-21 15:08:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 15:13:50 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 15:16:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ec71ef1d62b1719e0e7dc35e18ae21e02d2f8c
Cr-Commit-Position: refs/heads/master@{#440101}

Powered by Google App Engine
This is Rietveld 408576698