Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: src/profiler/profile-generator-inl.h

Issue 2588973003: Revert of [profiler] Add extra CHECK to track down crbug.com/665398 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/profile-generator-inl.h
diff --git a/src/profiler/profile-generator-inl.h b/src/profiler/profile-generator-inl.h
index 8e69ce4c67e96d1e5a82fcd0185935eeae2235ff..5a7017ad4907673b71402ebbb0b089ca30d40169 100644
--- a/src/profiler/profile-generator-inl.h
+++ b/src/profiler/profile-generator-inl.h
@@ -27,13 +27,7 @@
deopt_reason_(kNoDeoptReason),
deopt_id_(kNoDeoptimizationId),
line_info_(line_info),
- instruction_start_(instruction_start) {
-// TODO(alph): Extra check to help catch crbug.com/665398
-// Remove before 5.8 branch
-#if V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION == 7
- CHECK(name);
-#endif
-}
+ instruction_start_(instruction_start) {}
ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry,
ProfileNode* parent)
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698