Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h

Issue 2588943002: Disallow heap objects containing unsafe on-heap iterators. (Closed)
Patch Set: formatting Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
diff --git a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
index 18a791df6fe008227754dbc0415a9b7d00bcad65..c6ddd5edba1f239d989e39ff6f78f3d02d212251 100644
--- a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
+++ b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
@@ -28,7 +28,8 @@ class CheckFieldsVisitor : public RecursiveEdgeVisitor {
kMemberToGCUnmanaged,
kMemberInUnmanaged,
kPtrFromHeapToStack,
- kGCDerivedPartObject
+ kGCDerivedPartObject,
+ kIteratorToGCManaged,
};
using Errors = std::vector<std::pair<FieldPoint*, Error>>;
@@ -42,6 +43,7 @@ class CheckFieldsVisitor : public RecursiveEdgeVisitor {
void AtMember(Member* edge) override;
void AtValue(Value* edge) override;
void AtCollection(Collection* edge) override;
+ void AtIterator(Iterator*) override;
private:
Error InvalidSmartPtr(Edge* ptr);

Powered by Google App Engine
This is Rietveld 408576698