Disallow heap objects containing unsafe on-heap iterators.

tools/clang/blink_gc_plugin/tests/stack_allocated.txt

Index: tools/clang/blink_gc_plugin/tests/stack_allocated.txt
diff --git a/tools/clang/blink_gc_plugin/tests/stack_allocated.txt b/tools/clang/blink_gc_plugin/tests/stack_allocated.txt
index c6bb373736a2afe70f05285817d127f08b5ea696..6d33850161799c54f94da7e2ef3e2c7a16701272 100644
--- a/tools/clang/blink_gc_plugin/tests/stack_allocated.txt
+++ b/tools/clang/blink_gc_plugin/tests/stack_allocated.txt
@@ -20,7 +20,7 @@ class DerivedHeapObject2 : public HeapObject {
 ./stack_allocated.h:39:3: warning: [blink-gc] Garbage collected class 'DerivedHeapObject2' is not permitted to override its new operator.
   STACK_ALLOCATED();
   ^
-./heap/stubs.h:149:5: note: expanded from macro 'STACK_ALLOCATED'
+./heap/stubs.h:184:5: note: expanded from macro 'STACK_ALLOCATED'

[dcheng, 2016/12/20 21:23:46]

I think the test expectation is wrong. This is on line 178 of stubs.h, not line
184, which is causing me issues for rebasing my CL. I'm just going to update
this expectation.

[sof, 2016/12/20 21:30:28]

Thanks, please do. "git cl format" is a mixed blessing.

     __attribute__((annotate("blink_stack_allocated")))      \
     ^
 stack_allocated.cpp:12:1: warning: [blink-gc] Class 'AnonStackObject' contains invalid fields.