Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 258893010: Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU (Closed)

Created:
6 years, 7 months ago by caryclark
Modified:
6 years, 7 months ago
Reviewers:
humper, bsalomon, reed1
CC:
skia-review_googlegroups.com, ernstm, nduca
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU (https://codereview.chromium.org/248613004/) Reason for revert: Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio Original issue's description: > Fast path for blurred round rects -- blur a small 9patch rect on the CPU > And nonlinearly stretch the resulting texture across proxy geometry. > > BUG= > > Committed: http://code.google.com/p/skia/source/detail?r=14392 TBR=bsalomon@google.com,reed@google.com,humper@google.com NOTREECHECKS=true NOTRY=true BUG= Committed: http://code.google.com/p/skia/source/detail?r=14400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -300 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +7 lines, -9 lines 0 comments Download
M src/effects/SkBlurMask.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/effects/SkBlurMask.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +3 lines, -278 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
Created Revert of Fast path for blurred round rects -- blur a small 9patch rect ...
6 years, 7 months ago (2014-04-28 14:44:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/258893010/1
6 years, 7 months ago (2014-04-28 14:44:45 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:44:57 UTC) #3
Message was sent while issue was closed.
Change committed as 14400

Powered by Google App Engine
This is Rietveld 408576698