ios/chrome/browser/payments/payment_method_selection_view_controller.mm - Issue 2588913002: EarlGrey tests for Payment Request (base CL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/payments/payment_method_selection_view_controller.mm

Issue 2588913002: EarlGrey tests for Payment Request (base CL) (Closed)

Patch Set: Addressed comments by jdonnelly@ Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/payments/payment_items_display_view_controller.mm ('k') | ios/chrome/browser/payments/payment_request_manager.mm » ('j') | ios/chrome/browser/payments/payment_request_manager.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/payments/payment_method_selection_view_controller.mm

diff --git a/ios/chrome/browser/payments/payment_method_selection_view_controller.mm b/ios/chrome/browser/payments/payment_method_selection_view_controller.mm

index 500bc0a8685185fe8bbee0bb79c4479d2f6c5fa4..f3a169487c787e0f029a05924a10e5b561193bc2 100644

--- a/ios/chrome/browser/payments/payment_method_selection_view_controller.mm

+++ b/ios/chrome/browser/payments/payment_method_selection_view_controller.mm

@@ -62,6 +62,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

[ChromeIcon templateBarButtonItemWithImage:[ChromeIcon backIcon]

target:nil

action:@selector(onReturn)];

+ returnButton.accessibilityLabel = l10n_util::GetNSString(IDS_ACCNAME_BACK);

[self navigationItem].leftBarButtonItem = returnButton;

}

return self;

@@ -91,6 +92,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

autofill::CreditCard* paymentMethod = _paymentMethods[i];

PaymentMethodItem* paymentMethodItem = [[[PaymentMethodItem alloc]

initWithType:ItemTypePaymentMethod] autorelease];

+ paymentMethodItem.accessibilityTraits |= UIAccessibilityTraitButton;

paymentMethodItem.methodID =

base::SysUTF16ToNSString(paymentMethod->TypeAndLastFourDigits());

paymentMethodItem.methodDetail = base::SysUTF16ToNSString(