Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: ios/chrome/browser/payments/payment_items_display_view_controller.mm

Issue 2588913002: EarlGrey tests for Payment Request (base CL) (Closed)
Patch Set: Addressed comments by jdonnelly@ Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/payment_items_display_view_controller.mm
diff --git a/ios/chrome/browser/payments/payment_items_display_view_controller.mm b/ios/chrome/browser/payments/payment_items_display_view_controller.mm
index 7f79f5a717967fd0c4b0029f0580d941ba153fc2..202b2cde86bcb70f6f39d7f1222d4bec99c309bf 100644
--- a/ios/chrome/browser/payments/payment_items_display_view_controller.mm
+++ b/ios/chrome/browser/payments/payment_items_display_view_controller.mm
@@ -9,6 +9,7 @@
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "components/autofill/core/browser/credit_card.h"
+#include "components/strings/grit/components_strings.h"
#import "ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.h"
#import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
@@ -23,6 +24,7 @@
NSString* const kPaymentItemsDisplayCollectionViewId =
@"kPaymentItemsDisplayCollectionViewId";
+NSString* const kPaymentItemsDisplayItemId = @"kPaymentItemsDisplayItemId";
namespace {
@@ -68,6 +70,8 @@ typedef NS_ENUM(NSInteger, ItemType) {
[ChromeIcon templateBarButtonItemWithImage:[ChromeIcon backIcon]
target:nil
action:@selector(onReturn)];
+ [returnButton
+ setAccessibilityLabel:l10n_util::GetNSString(IDS_ACCNAME_BACK)];
[self navigationItem].leftBarButtonItem = returnButton;
// Set up right (pay) button.
@@ -144,6 +148,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
// Add the total entry.
CollectionViewDetailItem* totalItem = [[[CollectionViewDetailItem alloc]
initWithType:ItemTypePaymentItemTotal] autorelease];
+ totalItem.accessibilityIdentifier = kPaymentItemsDisplayItemId;
totalItem.text = base::SysUTF16ToNSString(_total.label);
NSString* currencyCode = base::SysUTF16ToNSString(_total.amount.currency);
@@ -160,6 +165,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
CollectionViewDetailItem* paymentItemItem =
[[[CollectionViewDetailItem alloc] initWithType:ItemTypePaymentItem]
autorelease];
+ paymentItemItem.accessibilityIdentifier = kPaymentItemsDisplayItemId;
paymentItemItem.text = base::SysUTF16ToNSString(paymentItem.label);
NSString* currencyCode =

Powered by Google App Engine
This is Rietveld 408576698