Delegate PersistedLogs metrics recording

Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

Also adds a missing histogram to histograms.xml

BUG=

Committed: https://crrev.com/961fa39abc108aaaa97f976d0e2c75a4619e9ad7
Cr-Commit-Position: refs/heads/master@{#440890}

[Steven Holte, 2016-12-19 20:53:51]

holte@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Steven Holte, 2016-12-19 21:08:19]

Description was changed from

==========
Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

BUG=
==========

to

==========
Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

Also adds a missing histogram to histograms.xml

BUG=
==========

[rkaplow, 2016-12-19 21:44:33]

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
File components/metrics/persisted_logs_metrics.h (right):

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
components/metrics/persisted_logs_metrics.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
nit 2016

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
components/metrics/persisted_logs_metrics.h:13: // Maintains a list of unsent
logs that are written and restored from disk.
fix comment

https://codereview.chromium.org/2588873002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2588873002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:98477: +  <int value="4"
label="LIST_SIZE_CORRUPTION"/>
this isn't matching 
https://codesearch.chromium.org/chromium/src/components/metrics/persisted_log...,
missing a couple of entries.

[Steven Holte, 2016-12-19 21:53:12]

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
File components/metrics/persisted_logs_metrics.h (right):

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
components/metrics/persisted_logs_metrics.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2016/12/19 21:44:33, rkaplow wrote:
> nit 2016

Done.

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
components/metrics/persisted_logs_metrics.h:13: // Maintains a list of unsent
logs that are written and restored from disk.
On 2016/12/19 21:44:33, rkaplow wrote:
> fix comment

Done.

https://codereview.chromium.org/2588873002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2588873002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:98477: +  <int value="4"
label="LIST_SIZE_CORRUPTION"/>
On 2016/12/19 21:44:33, rkaplow wrote:
> this isn't matching 
>
https://codesearch.chromium.org/chromium/src/components/metrics/persisted_log...,
> missing a couple of entries.

Good catch

[rkaplow, 2016-12-19 21:55:09]

lgtm

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
File components/metrics/persisted_logs_metrics.h (right):

https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
components/metrics/persisted_logs_metrics.h:13: // Maintains a list of unsent
logs that are written and restored from disk.
On 2016/12/19 21:53:12, Steven Holte wrote:
> On 2016/12/19 21:44:33, rkaplow wrote:
> > fix comment
> 
> Done.

Did the impl but missed the base here

[Steven Holte, 2016-12-19 22:10:44]

On 2016/12/19 21:55:09, rkaplow wrote:
> lgtm
> 
>
https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
> File components/metrics/persisted_logs_metrics.h (right):
> 
>
https://codereview.chromium.org/2588873002/diff/40001/components/metrics/pers...
> components/metrics/persisted_logs_metrics.h:13: // Maintains a list of unsent
> logs that are written and restored from disk.
> On 2016/12/19 21:53:12, Steven Holte wrote:
> > On 2016/12/19 21:44:33, rkaplow wrote:
> > > fix comment
> > 
> > Done.
> 
> Did the impl but missed the base here

Had the change unsaved in my editor...

[Steven Holte, 2016-12-28 00:17:20]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2016-12-28 00:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2588873002/#ps80001
(title: "Histogram description")

[commit-bot: I haz the power, 2016-12-28 00:17:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 00:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 00:24:13]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Steven Holte, 2016-12-28 20:10:15]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2016-12-28 20:10:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2588873002/#ps100001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-12-28 20:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 20:57:10]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482955815419840,
"parent_rev": "7ffb2374b286e6d27f98387a21b86b27b911a15c", "commit_rev":
"db9a4f07703590697e6aacbb68b01f5651e65e9f"}

[commit-bot: I haz the power, 2016-12-28 20:57:35]

Description was changed from

==========
Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

Also adds a missing histogram to histograms.xml

BUG=
==========

to

==========
Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

Also adds a missing histogram to histograms.xml

BUG=

Review-Url: https://codereview.chromium.org/2588873002
==========

[commit-bot: I haz the power, 2016-12-28 20:57:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2017-01-02 15:50:13]

Description was changed from

==========
Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

Also adds a missing histogram to histograms.xml

BUG=

Review-Url: https://codereview.chromium.org/2588873002
==========

to

==========
Delegate PersistedLogs metrics recording

Creates an object to perform PersistedLogs metrics recording, so that
they can be overriden in the UKM implementation.

Also adds a missing histogram to histograms.xml

BUG=

Committed: https://crrev.com/961fa39abc108aaaa97f976d0e2c75a4619e9ad7
Cr-Commit-Position: refs/heads/master@{#440890}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:13]

Patchset 6 (id:??) landed as
https://crrev.com/961fa39abc108aaaa97f976d0e2c75a4619e9ad7
Cr-Commit-Position: refs/heads/master@{#440890}