third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py - Issue 2588863002: Make MockExecutive behave more like MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

Issue 2588863002: Make MockExecutive behave more like MockExecutive2. (Closed)

Patch Set: Reformat args lists for MockHost, MockSystemHost. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

index f4eb155c27116675c6ce6d9fba7d3ff82337fa8c..96d8990459fcb818a2da98fd3ace04fd187a6d2e 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

@@ -93,6 +93,8 @@ class AndroidPortTest(port_testcase.PortTestCase):

def test_check_build(self):

host = MockSystemHost()

port = self.make_port(host=host, options=optparse.Values({'child_processes': 1}))

+ # Checking the devices is not tested in this unit test.

+ port._check_devices = lambda _: None

host.filesystem.exists = lambda p: True

port.check_build(needs_http=True, printer=port_testcase.FakePrinter())