third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py - Issue 2588863002: Make MockExecutive behave more like MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py

Issue 2588863002: Make MockExecutive behave more like MockExecutive2. (Closed)

Patch Set: Reformat args lists for MockHost, MockSystemHost. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py

index 1bff4c6cb74163cdb612fdecfe142eb5de8b5157..fcdd1e8aa3b7476b75c561047fff4c2c8ada3bfd 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py

@@ -37,10 +37,15 @@ from webkitpy.common.system.workspace_mock import MockWorkspace

class MockSystemHost(object):

- def __init__(self, log_executive=False, executive_throws_when_run=None, os_name=None,

- os_version=None, executive=None, filesystem=None, time_return_val=123):

+ def __init__(self,

+ log_executive=False,

+ os_name=None,

+ os_version=None,

+ executive=None,

+ filesystem=None,

+ time_return_val=123):

self.executable = 'python'

- self.executive = executive or MockExecutive(should_log=log_executive, should_throw_when_run=executive_throws_when_run)

+ self.executive = executive or MockExecutive(should_log=log_executive)

self.filesystem = filesystem or MockFileSystem()

self.user = MockUser()

self.platform = MockPlatformInfo()