Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: third_party/WebKit/Source/devtools/scripts/closure/closure_runner/build_compiler_runner_jar.py

Issue 2588843002: DevTools: speed up closure dependency checking (Closed)
Patch Set: update compile_frontend Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/scripts/closure/closure_runner/build_compiler_runner_jar.py
diff --git a/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/build_compiler_runner_jar.py b/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/build_compiler_runner_jar.py
deleted file mode 100755
index 9ff1091b25830f76151fbc53fc63436031635b64..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/build_compiler_runner_jar.py
+++ /dev/null
@@ -1,73 +0,0 @@
-#!/usr/bin/python
-
-import os
-import shutil
-import subprocess
-import sys
-import tempfile
-
-
-def rel_to_abs(rel_path):
- return os.path.join(script_path, rel_path)
-
-
-java_bin_path = os.getenv('JAVA_HOME', '')
-if java_bin_path:
- java_bin_path = os.path.join(java_bin_path, 'bin')
-
-main_class = 'org.chromium.devtools.compiler.Runner'
-jar_name = 'closure_runner.jar'
-src_dir = 'src'
-script_path = os.path.dirname(os.path.abspath(__file__))
-closure_jar_relpath = os.path.join('..', 'compiler.jar')
-src_path = rel_to_abs(src_dir)
-
-
-def run_and_communicate(command, error_template):
- proc = subprocess.Popen(command, stdout=subprocess.PIPE, shell=True)
- proc.communicate()
- if proc.returncode:
- print >> sys.stderr, error_template % proc.returncode
- sys.exit(proc.returncode)
-
-
-def build_artifacts():
- print 'Compiling...'
- java_files = []
- for root, dirs, files in sorted(os.walk(src_path)):
- for file_name in files:
- java_files.append(os.path.join(root, file_name))
-
- bin_path = tempfile.mkdtemp()
- manifest_file = tempfile.NamedTemporaryFile(mode='wt', delete=False)
- try:
- manifest_file.write('Class-Path: %s\n' % closure_jar_relpath)
- manifest_file.close()
- javac_path = os.path.join(java_bin_path, 'javac')
- javac_command = '%s -target 7 -source 7 -d %s -cp %s %s' % (javac_path, bin_path, rel_to_abs(closure_jar_relpath), ' '.join(java_files))
- run_and_communicate(javac_command, 'Error: javac returned %d')
-
- print 'Building jar...'
- artifact_path = rel_to_abs(jar_name)
- jar_path = os.path.join(java_bin_path, 'jar')
- jar_command = '%s cvfme %s %s %s -C %s .' % (jar_path, artifact_path, manifest_file.name, main_class, bin_path)
- run_and_communicate(jar_command, 'Error: jar returned %d')
- finally:
- os.remove(manifest_file.name)
- shutil.rmtree(bin_path, True)
-
-
-def help():
- print 'usage: %s' % os.path.basename(__file__)
- print 'Builds closure_runner.jar from the %s directory contents' % src_dir
-
-
-def main():
- if len(sys.argv) > 1:
- help()
- return
- build_artifacts()
- print 'Done.'
-
-if __name__ == '__main__':
- main()

Powered by Google App Engine
This is Rietveld 408576698