Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

Issue 2588843002: DevTools: speed up closure dependency checking (Closed)
Patch Set: update compile_frontend Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
diff --git a/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java b/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
deleted file mode 100644
index a238589037377f7f0a86753adb5b4ecbb3de6b90..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
+++ /dev/null
@@ -1,21 +0,0 @@
-package org.chromium.devtools.compiler;
-
-import com.google.javascript.jscomp.CodingConventions;
-
-public class DevToolsCodingConvention extends CodingConventions.Proxy {
- private static final long serialVersionUID = 1L;
-
- public DevToolsCodingConvention() {
- super(CodingConventions.getDefault());
- }
-
- @Override
- public boolean isPrivate(String name) {
- return name.length() > 1 && name.charAt(0) == '_' && name.charAt(1) != '_';
dgozman 2016/12/20 07:02:18 What is this replaced with?
chenwilliam 2016/12/20 20:23:35 I was too eager to delete closure runner :( I did
- }
-
- @Override
- public boolean isValidEnumKey(String key) {
- return !key.isEmpty() && Character.isUpperCase(key.charAt(0));
- }
-}

Powered by Google App Engine
This is Rietveld 408576698