Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2588733002: Upstream Chrome on iOS source code [9/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Chrome on iOS source code [9/11]. Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Committed: https://crrev.com/2fd5938985347068114d6a8e5c1da17bab9bbb17 Cr-Commit-Position: refs/heads/master@{#439473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20085 lines, -0 lines) Patch
A ios/chrome/browser/ui/tab_grid/README.md View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 1 chunk +133 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_grid/tab_grid_tab_cell.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm View 1 chunk +150 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/session_changes.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/session_changes.mm View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_model_snapshot.mm View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_model_snapshot_unittest.mm View 1 chunk +90 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher.h View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_button.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_button.mm View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_cache.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_cache.mm View 1 chunk +274 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm View 1 chunk +1249 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm View 1 chunk +221 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_header_cell.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_header_cell.mm View 1 chunk +89 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.mm View 1 chunk +396 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h View 1 chunk +110 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm View 1 chunk +410 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_model_private.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_model_unittest.mm View 1 chunk +434 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h View 1 chunk +69 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm View 1 chunk +456 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_collection_view_layout.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_collection_view_layout.mm View 1 chunk +153 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.h View 1 chunk +101 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm View 1 chunk +335 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm View 1 chunk +420 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_view.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_view.mm View 1 chunk +78 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.mm View 1 chunk +91 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_tab_strip_placeholder_view.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_tab_strip_placeholder_view.mm View 1 chunk +166 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.h View 1 chunk +65 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_context.mm View 1 chunk +119 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm View 1 chunk +190 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_utils_unittest.mm View 1 chunk +126 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_view.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/tab_switcher_view.mm View 1 chunk +368 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_controller.h View 1 chunk +66 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_controller.mm View 1 chunk +1666 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_controller+tab_switcher_animation.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_controller_private.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_controller_unittest.mm View 1 chunk +168 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_egtest.mm View 1 chunk +104 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_view.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_strip_view.mm View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_util.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_util.mm View 1 chunk +72 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_view.h View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/tab_view.mm View 1 chunk +380 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/target_frame_cache.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tabs/target_frame_cache.mm View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/README.md View 1 chunk +10 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/new_tab_button.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/new_tab_button.mm View 1 chunk +84 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.h View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm View 1 chunk +57 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_button_tints.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_button_tints.mm View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_controller.h View 1 chunk +288 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 1 chunk +1065 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_controller+protected.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_controller_private.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm View 1 chunk +91 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_coordinator.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_coordinator.mm View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_egtest.mm View 1 chunk +451 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm View 1 chunk +107 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.mm View 1 chunk +84 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm View 1 chunk +220 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_model_ios.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_owner.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_resource_macros.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm View 1 chunk +68 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_view_controller.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/toolbar_view_controller.mm View 1 chunk +96 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/web_toolbar_controller.h View 1 chunk +169 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 1 chunk +2573 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/web_toolbar_controller_private.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm View 1 chunk +221 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools/menu_view_controller.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools/menu_view_controller.mm View 1 chunk +73 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools/tools_coordinator.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools/tools_coordinator.mm View 1 chunk +73 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/new_menu_view_item.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_context.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_context.mm View 1 chunk +69 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h View 1 chunk +96 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 1 chunk +958 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm View 1 chunk +159 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_popup_controller.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm View 1 chunk +237 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm View 1 chunk +169 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/ui_types.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/CRUILabel+AttributeUtils.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/CRUILabel+AttributeUtils.mm View 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/CRUILabel+AttributeUtils_unittest.mm View 1 chunk +101 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/core_text_util.h View 1 chunk +85 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/core_text_util.mm View 1 chunk +226 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/core_text_util_unittest.mm View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/label_link_controller.h View 1 chunk +76 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/label_link_controller.mm View 1 chunk +451 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/label_link_controller_unittest.mm View 1 chunk +291 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/label_observer.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/label_observer.mm View 1 chunk +189 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/label_observer_unittest.mm View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-19 14:33:41 UTC) #4
rohitrao (ping after 24h)
lgtm!
4 years ago (2016-12-19 14:36:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588733002/1
4 years ago (2016-12-19 14:44:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 14:50:45 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 14:53:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fd5938985347068114d6a8e5c1da17bab9bbb17
Cr-Commit-Position: refs/heads/master@{#439473}

Powered by Google App Engine
This is Rietveld 408576698