Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2588673002: Fix layout test editing/spelling/spellcheck-queue.html (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout test editing/spelling/spellcheck-queue.html Layout test editing/spelling/spellcheck-queue.html expected spelling markers to appear in <input> without focus, which is wrong and is changed in this patch. This patch does not fix the wrong behavior of adding markers into an <input> without focus. Idle time spell checking will fix it. BUG=n/a Committed: https://crrev.com/b40fdd61c57f914d5c7a39e7a3e391df05f52601 Cr-Commit-Position: refs/heads/master@{#439637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-queue.html View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-20 00:22:42 UTC) #6
tkent
lgtm
4 years ago (2016-12-20 00:31:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588673002/1
4 years ago (2016-12-20 00:33:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:39:46 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 00:41:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b40fdd61c57f914d5c7a39e7a3e391df05f52601
Cr-Commit-Position: refs/heads/master@{#439637}

Powered by Google App Engine
This is Rietveld 408576698