Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2588653002: [Command buffer] Fix a bug for early return in blitFramebuffer (Closed)

Created:
4 years ago by yunchao
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Command buffer] Fix a bug for early return in blitFramebuffer BUG=672719 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3778159fc2c65c4d7dabaa0a5b07653aa29343d4 Cr-Commit-Position: refs/heads/master@{#439680}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 5 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
yunchao
Zhenyao (and others), PTAL. See the conformance test at https://github.com/KhronosGroup/WebGL/pull/2212, which can expose the error ...
4 years ago (2016-12-19 10:24:35 UTC) #4
Zhenyao Mo
On 2016/12/19 10:24:35, yunchao wrote: > Zhenyao (and others), PTAL. > > See the conformance ...
4 years ago (2016-12-20 00:26:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588653002/20001
4 years ago (2016-12-20 02:43:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 02:48:35 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-20 02:51:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3778159fc2c65c4d7dabaa0a5b07653aa29343d4
Cr-Commit-Position: refs/heads/master@{#439680}

Powered by Google App Engine
This is Rietveld 408576698