Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2588633002: Roll buildtools 55ad626b08..0ef8010876 (Closed)

Created:
4 years ago by Dirk Pranke
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 55ad626b08..0ef8010876 In order to roll GN 8897c835c2..c99acd6557 (r436733:r439377) and pick up the following changes: 8d1f54e Revert GN declare_args() change. a0835ee tracing: split trace event filter classes out of TraceLog 3a5f162 Restore clang-format formatting. dc72ee94 Make base::Value::TYPE a scoped enum. cdeaacd Clean formatting after http://crrev.com/2544803002/. db24b9e Cleanup remaining class/struct fwd declarations TBR=brettw@chromium.org Committed: https://crrev.com/1791c73e9c10c356a1121f85f685de401e27a511 Cr-Commit-Position: refs/heads/master@{#439384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Dirk Pranke
4 years ago (2016-12-18 22:03:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588633002/1
4 years ago (2016-12-18 22:04:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 22:55:04 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-18 22:56:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1791c73e9c10c356a1121f85f685de401e27a511
Cr-Commit-Position: refs/heads/master@{#439384}

Powered by Google App Engine
This is Rietveld 408576698