Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2588583002: Rewrite the layout test for DOMPoint interface. (Closed)

Created:
4 years ago by Byoungkwon Ko
Modified:
4 years ago
Reviewers:
zino
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite the layout test for DOMPoint interface. For historical reasons, older tests are written using the js-test harness. This harness is deprecated, and should not be used for new tests. So, rewrite the layout test as following new tests guide[1]. [1] https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md#The-js_test_js-Legacy-Harness BUG=675437 Committed: https://crrev.com/74be73dbbb415e0e66dafe43c04d9842c2912f61 Cr-Commit-Position: refs/heads/master@{#439370}

Patch Set 1 #

Patch Set 2 : Rewrite the layout test for DOMPoint interface. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -175 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html View 1 1 chunk +51 lines, -100 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-expected.txt View 1 chunk +0 lines, -75 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Byoungkwon Ko
PATL
4 years ago (2016-12-18 10:46:44 UTC) #3
zino
On 2016/12/18 10:46:44, Byoungkwon Ko wrote: > PATL lgtm
4 years ago (2016-12-18 12:43:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588583002/20001
4 years ago (2016-12-18 13:15:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-18 13:20:45 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-18 13:23:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74be73dbbb415e0e66dafe43c04d9842c2912f61
Cr-Commit-Position: refs/heads/master@{#439370}

Powered by Google App Engine
This is Rietveld 408576698