Add policies for controlling the roaming profile status and location.

Add policies for controlling the roaming profile status and location.

Introduces two new policies:

RoamingProfileSupportEnabled which is tied to the the
kLocalSyncBackendEnabled pref and starts or stops the roaming profile
support.

RoamingProfileLocation which specifies the location for the roaming
profile file and is tied to the kLocalSyncBackendLocation pref.

BUG=651411
TEST=browser_tests

Committed: https://crrev.com/6c8750f1522c8c67c16d40de5d7c91ecb181b8f9
Cr-Commit-Position: refs/heads/master@{#440427}

[pastarmovj, 2016-12-21 12:59:17]

pastarmovj@chromium.org changed reviewers:
+ tnagel@chromium.org

[pastarmovj, 2016-12-21 12:59:17]

Hi Thiemo,

can you please review this change.

Thanks,
Julian

[pastarmovj, 2016-12-21 13:05:11]

The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 13:05:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pastarmovj, 2016-12-21 13:47:35]

pastarmovj@chromium.org changed reviewers:
+ isherman@chromium.org

[pastarmovj, 2016-12-21 13:47:35]

+isherman for histograms.xml.

[commit-bot: I haz the power, 2016-12-21 13:56:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 13:56:32]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-12-22 01:14:54]

histograms.xml lgtm

[pastarmovj, 2016-12-22 11:08:06]

pastarmovj@chromium.org changed reviewers:
+ emaxx@chromium.org
- tnagel@chromium.org

[pastarmovj, 2016-12-22 11:08:06]

Swapping Thiemo for Maksim due to time constraints.

[emaxx, 2016-12-22 13:05:24]

lgtm

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:1491: If you enable this
setting, the settings stored in <ph name="PRODUCT_NAME">$1<ex>Google
Chrome</ex></ph> profiles like bookmarks, autofill data, passwords etc. will
also be written to a file stored in the Roaming user profile folder or a
location specified by the Administrator through the <ph
name="ROAMINGPROFILELOCATION_POLICY_NAME">$1<ex>RoamingProfileLocation</ex></ph>
policy.
nit: s/ etc./, etc./

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:1495: To prevent accidental
data leaks it is advisable to also set the <ph
name="SIGNINALLOWED_POLICY_NAME">$1<ex>SigninAllowed</ex></ph> policy to False.
The SigninAllowed policy is deprecated:
https://www.chromium.org/administrators/policy-list-3#SigninAllowed
The docs recommend using SyncDisabled instead. Though it's not clear to me
whether this policy would make sense in this context.

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:1498: },
Not sure, but maybe it would make sense to add 'label' here too, as for the
RoamingProfileLocation policy.

[pastarmovj, 2016-12-22 13:19:51]

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:1491: If you enable this
setting, the settings stored in <ph name="PRODUCT_NAME">$1<ex>Google
Chrome</ex></ph> profiles like bookmarks, autofill data, passwords etc. will
also be written to a file stored in the Roaming user profile folder or a
location specified by the Administrator through the <ph
name="ROAMINGPROFILELOCATION_POLICY_NAME">$1<ex>RoamingProfileLocation</ex></ph>
policy.
On 2016/12/22 13:05:24, emaxx wrote:
> nit: s/ etc./, etc./

Done.

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:1495: To prevent accidental
data leaks it is advisable to also set the <ph
name="SIGNINALLOWED_POLICY_NAME">$1<ex>SigninAllowed</ex></ph> policy to False.
On 2016/12/22 13:05:24, emaxx wrote:
> The SigninAllowed policy is deprecated:
> https://www.chromium.org/administrators/policy-list-3#SigninAllowed
> The docs recommend using SyncDisabled instead. Though it's not clear to me
> whether this policy would make sense in this context.

As per discussion. The policy should still work but the documentation is not
correct right now.

I filed http://crbug/676619 to track this issue.

https://codereview.chromium.org/2588423005/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:1498: },
On 2016/12/22 13:05:24, emaxx wrote:
> Not sure, but maybe it would make sense to add 'label' here too, as for the
> RoamingProfileLocation policy.

Done.

[pastarmovj, 2016-12-22 13:19:56]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-12-22 13:20:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pastarmovj, 2016-12-22 14:33:48]

The CQ bit was unchecked by pastarmovj@chromium.org

[pastarmovj, 2016-12-22 14:35:47]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2016-12-22 14:35:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2588423005/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-12-22 14:36:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 15:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482417347794320,
"parent_rev": "1ba42b4ba7ea4163c0a65b274026481491be53ea", "commit_rev":
"6227e1f28886d29020618d4f48dd3cd840769217"}

[commit-bot: I haz the power, 2016-12-22 15:44:04]

Description was changed from

==========
Add policies for controlling the roaming profile status and location.

Introduces two new policies:

RoamingProfileSupportEnabled which is tied to the the
kLocalSyncBackendEnabled pref and starts or stops the roaming profile
support.

RoamingProfileLocation which specifies the location for the roaming
profile file and is tied to the kLocalSyncBackendLocation pref.

BUG=651411
TEST=browser_tests
==========

to

==========
Add policies for controlling the roaming profile status and location.

Introduces two new policies:

RoamingProfileSupportEnabled which is tied to the the
kLocalSyncBackendEnabled pref and starts or stops the roaming profile
support.

RoamingProfileLocation which specifies the location for the roaming
profile file and is tied to the kLocalSyncBackendLocation pref.

BUG=651411
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2588423005
==========

[commit-bot: I haz the power, 2016-12-22 15:44:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-22 15:47:43]

Description was changed from

==========
Add policies for controlling the roaming profile status and location.

Introduces two new policies:

RoamingProfileSupportEnabled which is tied to the the
kLocalSyncBackendEnabled pref and starts or stops the roaming profile
support.

RoamingProfileLocation which specifies the location for the roaming
profile file and is tied to the kLocalSyncBackendLocation pref.

BUG=651411
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2588423005
==========

to

==========
Add policies for controlling the roaming profile status and location.

Introduces two new policies:

RoamingProfileSupportEnabled which is tied to the the
kLocalSyncBackendEnabled pref and starts or stops the roaming profile
support.

RoamingProfileLocation which specifies the location for the roaming
profile file and is tied to the kLocalSyncBackendLocation pref.

BUG=651411
TEST=browser_tests

Committed: https://crrev.com/6c8750f1522c8c67c16d40de5d7c91ecb181b8f9
Cr-Commit-Position: refs/heads/master@{#440427}
==========

[commit-bot: I haz the power, 2016-12-22 15:47:44]

Patchset 2 (id:??) landed as
https://crrev.com/6c8750f1522c8c67c16d40de5d7c91ecb181b8f9
Cr-Commit-Position: refs/heads/master@{#440427}