Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2588363002: Disable API call inline in TF when gather runtime stats (Closed)

Created:
4 years ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable API call inline in TF when gather runtime stats BUG=none R=epertoso@chromium.org,mvstanton@chromium.org,cbruni@chromium.org Review-Url: https://codereview.chromium.org/2588363002 Cr-Commit-Position: refs/heads/master@{#41854} Committed: https://chromium.googlesource.com/v8/v8/+/55c88e586badc6b29215c9a068900df13ea88721

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M src/compiler/js-call-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 5 chunks +23 lines, -16 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
jochen (gone - plz use gerrit)
4 years ago (2016-12-20 11:30:39 UTC) #1
epertoso
lgtm
4 years ago (2016-12-20 11:41:41 UTC) #2
Camillo Bruni
lgtm
4 years ago (2016-12-20 11:52:02 UTC) #5
mvstanton
lgtm
4 years ago (2016-12-20 11:55:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588363002/1
4 years ago (2016-12-20 11:56:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/55c88e586badc6b29215c9a068900df13ea88721
4 years ago (2016-12-20 12:10:54 UTC) #12
Toon Verwaest
3 years, 11 months ago (2017-01-10 13:34:57 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2588363002/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2588363002/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:1025: } else {
This is broken; if CanInlineApiCall returns false due to --runtime-call-stats,
you won't have a JSFunction and the code below can only deal with JSFunctions.

Powered by Google App Engine
This is Rietveld 408576698