CSS Transitions: Fix flaky cancel-and-start-new.html

CSS Transitions: Fix flaky cancel-and-start-new.html

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938
Committed: https://crrev.com/99068a3f81583780d61d61167e268991269f3822
Cr-Commit-Position: refs/heads/master@{#440817}

[Eric Willigers, 2016-12-20 06:32:53]

ericwilligers@chromium.org changed reviewers:
+ suzyh@chromium.org

[Eric Willigers, 2016-12-20 06:32:59]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 06:33:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 08:01:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 08:01:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2016-12-21 00:26:59]

lgtm

So much easier to read. Simple tests is best tests!

https://codereview.chromium.org/2588313002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html
(right):

https://codereview.chromium.org/2588313002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:36:
target.classList.remove('transition-top');
Do we care about the correctness of the transition-top behaviour? That is, do we
care about the value of top at any point?

[Eric Willigers, 2016-12-21 01:01:12]

https://codereview.chromium.org/2588313002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html
(right):

https://codereview.chromium.org/2588313002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:36:
target.classList.remove('transition-top');
On 2016/12/21 00:26:59, suzyh wrote:
> Do we care about the correctness of the transition-top behaviour? That is, do
we
> care about the value of top at any point?

I've now added an assert that the value returns to 0 after the transition is
cancelled.

If we check the value during the transition, the test will become more complex
or flaky.

[Eric Willigers, 2016-12-21 01:01:18]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-12-21 01:01:18]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2588313002/#ps20001
(title: ""top test"")

[commit-bot: I haz the power, 2016-12-21 01:02:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 02:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:42:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2016-12-28 00:08:20]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 00:08:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 01:35:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 01:35:20]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-12-28 01:42:45]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-12-28 01:42:46]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2588313002/#ps40001
(title: "reduce test duration")

[commit-bot: I haz the power, 2016-12-28 01:43:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 01:46:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482889365863840,
"parent_rev": "5a49f8c1b51cfc60b2edfab5c79b963946a54ce9", "commit_rev":
"b57b67d8e43f8eeb3091d73473a0f599378c0659"}

[commit-bot: I haz the power, 2016-12-28 01:47:26]

Description was changed from

==========
CSS Transitions: Fix flaky cancel-and-start-new.html

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938
==========

to

==========
CSS Transitions: Fix flaky cancel-and-start-new.html

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938

Review-Url: https://codereview.chromium.org/2588313002
==========

[commit-bot: I haz the power, 2016-12-28 01:47:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-02 15:48:08]

Description was changed from

==========
CSS Transitions: Fix flaky cancel-and-start-new.html

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938

Review-Url: https://codereview.chromium.org/2588313002
==========

to

==========
CSS Transitions: Fix flaky cancel-and-start-new.html

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938

Committed: https://crrev.com/99068a3f81583780d61d61167e268991269f3822
Cr-Commit-Position: refs/heads/master@{#440817}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:08]

Patchset 3 (id:??) landed as
https://crrev.com/99068a3f81583780d61d61167e268991269f3822
Cr-Commit-Position: refs/heads/master@{#440817}