Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2588303003: [NTP::PhysicalWeb] Move Physical Web section to the top. (Closed)

Created:
4 years ago by vitaliii
Modified:
4 years ago
Reviewers:
jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::PhysicalWeb] Move Physical Web section to the top. According to the PRD the Physical Web section should be first on the NTP. BUG=674890 Committed: https://crrev.com/374735e0c4263d52a2dc8409e33773cf071fb20b Cr-Commit-Position: refs/heads/master@{#439777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/category_rankers/constant_category_ranker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
vitaliii
[XS CL - 2 lines] Hi jkrcal@, Could you have a look?
4 years ago (2016-12-20 10:20:17 UTC) #2
jkrcal
lgtm
4 years ago (2016-12-20 10:29:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588303003/1
4 years ago (2016-12-20 10:30:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 12:39:21 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 12:41:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/374735e0c4263d52a2dc8409e33773cf071fb20b
Cr-Commit-Position: refs/heads/master@{#439777}

Powered by Google App Engine
This is Rietveld 408576698