Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2588293005: Shape Detection: Add Text Detection in Chrome Android (Closed)

Created:
4 years ago by xianglu
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, haraken, jam, qsr+mojo_chromium.org, Reilly Grant (use Gerrit), viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shape Detection: Add Text Detection in Chrome Android This CL adds text detection API in addition to face detection and barcode detection. It uses com.google.android.gms package and is registered in ChromeInterfaceRegistrar.java. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JkdoxpINjxQ BUG=676124 SPEC= https://wicg.github.io/shape-detection-api/#text-detection-api TEST(Layout)= third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html DEMO= https://s.codepen.io/xianglu_google/debug/pNGBKv https://s.codepen.io/xianglu_google/debug/QGoaYe https://drive.google.com/file/d/0B3T2kSOMuTq3aFhZelAxTFdNWUk/view?usp=sharing (video) Review-Url: https://codereview.chromium.org/2588293005 Cr-Commit-Position: refs/heads/master@{#442293} Committed: https://chromium.googlesource.com/chromium/src/+/bbe29b0276f347c3619cdc33fcb6540eef466bb9

Patch Set 1 #

Total comments: 4

Patch Set 2 : Change binding interface for mock-textdetection, rebase #

Total comments: 3

Patch Set 3 : 2016=>2017 #

Total comments: 4

Patch Set 4 : jochen@ comments, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html View 3 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js View 1 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/Source/modules/shapedetection/DetectedText.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/shapedetection/DetectedText.idl View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/Source/modules/shapedetection/TextDetector.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/shapedetection/TextDetector.idl View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/shapedetection/textdetection.mojom View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 143 (125 generated)
xianglu
PTAL.
4 years ago (2016-12-23 00:09:44 UTC) #77
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2588293005/diff/260001/third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt File third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt (right): https://codereview.chromium.org/2588293005/diff/260001/third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt#newcode13 third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt:13: This file looks unrelated to your change. https://codereview.chromium.org/2588293005/diff/260001/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js File ...
4 years ago (2016-12-23 02:24:28 UTC) #82
xianglu
Please take another look. Thanks! https://codereview.chromium.org/2588293005/diff/260001/third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt File third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt (right): https://codereview.chromium.org/2588293005/diff/260001/third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt#newcode13 third_party/WebKit/LayoutTests/media/autoplay-muted-expected.txt:13: On 2016/12/23 02:24:28, Reilly ...
3 years, 11 months ago (2017-01-03 20:47:28 UTC) #90
Reilly Grant (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-03 21:58:04 UTC) #91
xianglu
PTAL.
3 years, 11 months ago (2017-01-03 22:36:31 UTC) #96
Tom Sepez
mojom LGTM
3 years, 11 months ago (2017-01-03 22:38:13 UTC) #97
Maria
3 years, 11 months ago (2017-01-03 23:04:02 UTC) #99
David Trainor- moved to gerrit
java lgtm % nit https://codereview.chromium.org/2588293005/diff/300001/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java File chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java (right): https://codereview.chromium.org/2588293005/diff/300001/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java#newcode97 chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java:97: detectedTextArray[i].boundingBox = new RectF(); new ...
3 years, 11 months ago (2017-01-03 23:38:20 UTC) #100
xianglu
https://codereview.chromium.org/2588293005/diff/300001/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java File chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java (right): https://codereview.chromium.org/2588293005/diff/300001/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java#newcode97 chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java:97: detectedTextArray[i].boundingBox = new RectF(); On 2017/01/03 23:38:20, David Trainor ...
3 years, 11 months ago (2017-01-04 01:56:59 UTC) #101
jochen (gone - plz use gerrit)
can you please add a link to the "intent to implement" thread on blink-dev to ...
3 years, 11 months ago (2017-01-04 08:52:06 UTC) #102
haraken
WebKit/ implementation LGTM https://codereview.chromium.org/2588293005/diff/300001/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp File third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp (right): https://codereview.chromium.org/2588293005/diff/300001/third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp#newcode1 third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp:1: // Copyright 2016 The Chromium Authors. ...
3 years, 11 months ago (2017-01-04 12:10:31 UTC) #103
xianglu
On 2017/01/04 08:52:06, jochen wrote: > can you please add a link to the "intent ...
3 years, 11 months ago (2017-01-04 18:19:03 UTC) #106
David Trainor- moved to gerrit
Ah my bad I thought it was the android RectF class. Thanks!
3 years, 11 months ago (2017-01-04 22:19:08 UTC) #125
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2588293005/diff/400001/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl File third_party/WebKit/Source/modules/shapedetection/DetectedText.idl (right): https://codereview.chromium.org/2588293005/diff/400001/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl#newcode11 third_party/WebKit/Source/modules/shapedetection/DetectedText.idl:11: [SameObject] readonly attribute DOMString rawValue; nit. can you switch ...
3 years, 11 months ago (2017-01-05 12:11:55 UTC) #126
xianglu
https://codereview.chromium.org/2588293005/diff/400001/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl File third_party/WebKit/Source/modules/shapedetection/DetectedText.idl (right): https://codereview.chromium.org/2588293005/diff/400001/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl#newcode11 third_party/WebKit/Source/modules/shapedetection/DetectedText.idl:11: [SameObject] readonly attribute DOMString rawValue; On 2017/01/05 12:11:55, jochen ...
3 years, 11 months ago (2017-01-05 20:04:20 UTC) #133
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-09 08:39:04 UTC) #137
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588293005/420001
3 years, 11 months ago (2017-01-09 16:12:08 UTC) #140
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:13:16 UTC) #143
Message was sent while issue was closed. 
Committed patchset #4 (id:420001) as
https://chromium.googlesource.com/chromium/src/+/bbe29b0276f347c3619cdc33fcb6...

Powered by Google App Engine
This is Rietveld 408576698