|
|
Chromium Code Reviews|
Created:
4 years ago by Marijn Kruisselbrink Modified:
4 years ago CC:
chromium-reviews, darin-cc_chromium.org, jam Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTest most of the rest of the LevelDBWrapper public API.
Adds tests for Delete and DeleteAll, as well as adding verification of
observations. Changes the tests to actually set up a mojo MessagePipe
as well to more realistically test these things.
BUG=586194
Committed: https://crrev.com/eea75a43081215ea5e5196fa23d2016ca561f77a
Cr-Commit-Position: refs/heads/master@{#440223}
Patch Set 1 #Patch Set 2 : rebase, and try to fix windows compile #
Dependent Patchsets: Messages
Total messages: 19 (14 generated)
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Improve LevelDBWrapperImpl tests. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 ========== to ========== Test most of the rest of the LevelDBWrapper public API. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 ==========
mek@chromium.org changed reviewers: + jam@chromium.org, michaeln@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm 👍
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482355627613630,
"parent_rev": "ade06bdb35af351f69a60f07154ec8b0a716964e", "commit_rev":
"922fdc7ea9ab5d4bcd9ee8ad05ee31d2ae48143f"}
Message was sent while issue was closed.
Description was changed from ========== Test most of the rest of the LevelDBWrapper public API. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 ========== to ========== Test most of the rest of the LevelDBWrapper public API. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 Review-Url: https://codereview.chromium.org/2588273005 Committed: https://chromium.googlesource.com/chromium/src/+/922fdc7ea9ab5d4bcd9ee8ad05ee... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/922fdc7ea9ab5d4bcd9ee8ad05ee...
Message was sent while issue was closed.
Description was changed from ========== Test most of the rest of the LevelDBWrapper public API. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 Review-Url: https://codereview.chromium.org/2588273005 Committed: https://chromium.googlesource.com/chromium/src/+/922fdc7ea9ab5d4bcd9ee8ad05ee... ========== to ========== Test most of the rest of the LevelDBWrapper public API. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 Committed: https://crrev.com/eea75a43081215ea5e5196fa23d2016ca561f77a Cr-Commit-Position: refs/heads/master@{#440223} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eea75a43081215ea5e5196fa23d2016ca561f77a Cr-Commit-Position: refs/heads/master@{#440223} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
