Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2588273005: Test most of the rest of the LevelDBWrapper public API. (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
4 years ago
Reviewers:
michaeln, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test most of the rest of the LevelDBWrapper public API. Adds tests for Delete and DeleteAll, as well as adding verification of observations. Changes the tests to actually set up a mojo MessagePipe as well to more realistically test these things. BUG=586194 Committed: https://crrev.com/eea75a43081215ea5e5196fa23d2016ca561f77a Cr-Commit-Position: refs/heads/master@{#440223}

Patch Set 1 #

Patch Set 2 : rebase, and try to fix windows compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -134 lines) Patch
M content/browser/leveldb_wrapper_impl_unittest.cc View 1 10 chunks +222 lines, -134 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Marijn Kruisselbrink
4 years ago (2016-12-21 18:27:31 UTC) #9
jam
lgtm 👍
4 years ago (2016-12-21 21:22:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588273005/20001
4 years ago (2016-12-21 21:27:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/922fdc7ea9ab5d4bcd9ee8ad05ee31d2ae48143f
4 years ago (2016-12-21 21:33:07 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-21 21:34:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eea75a43081215ea5e5196fa23d2016ca561f77a
Cr-Commit-Position: refs/heads/master@{#440223}

Powered by Google App Engine
This is Rietveld 408576698