Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issue 2588223002: [ios] Restore the original key window at the end of the AlertCoordinator tests. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
sdefresne, lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Restore the original key window at the end of unittests. Some tests were setting a new key window but failing to restore the original window after the test concluded. Leaving the app without a key window breaks subsequent tests on iOS 9.0, including ContextualSearchJsTest. BUG=None Committed: https://crrev.com/dfd26881f5803319e640fd302af56ed96eeb91de Cr-Commit-Position: refs/heads/master@{#439679}

Patch Set 1 #

Total comments: 1

Patch Set 2 : One more test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/context_menu/context_menu_coordinator_unittest.mm View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
sdefresne
https://codereview.chromium.org/2588223002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm File ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm (right): https://codereview.chromium.org/2588223002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm#newcode34 ios/chrome/browser/ui/alert_coordinator/alert_coordinator_unittest.mm:34: void TearDown() override { [previous_key_window_ makeKeyAndVisible]; } Should be ...
4 years ago (2016-12-20 02:08:55 UTC) #4
lpromero
lgtm
4 years ago (2016-12-20 02:09:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588223002/20001
4 years ago (2016-12-20 02:42:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 02:46:41 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-20 02:48:46 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfd26881f5803319e640fd302af56ed96eeb91de
Cr-Commit-Position: refs/heads/master@{#439679}

Powered by Google App Engine
This is Rietveld 408576698