|
|
DescriptionRun Chrome EarlGrey tests on FYI.
Now that Chrome can be built upstream, we should run integration
tests.
BUG=675788
Committed: https://crrev.com/6c5381ffdf7c3b8efc3bb9b190bbb10d1d7f003d
Cr-Commit-Position: refs/heads/master@{#439668}
Patch Set 1 #Patch Set 2 : integration suite #
Total comments: 3
Patch Set 3 : remove reading list #Messages
Total messages: 19 (8 generated)
baxley@chromium.org changed reviewers: + rohitrao@chromium.org, sdefresne@chromium.org
lgtm FYI means we can make changes aggressively. Let's turn these on and see how they do?
rohitrao@chromium.org changed reviewers: + smut@google.com
Only thing we have to watch for is capacity. +smut because we'll be adding additional load to the swarming bots.
On 2016/12/20 00:50:03, rohitrao wrote: > Only thing we have to watch for is capacity. +smut because we'll be adding > additional load to the swarming bots. lgtm let's see what hit capacity takes. I suspect we need more because a lot more stuff has been added lately.
sdefresne@chromium.org changed reviewers: + olivierrobin@chromium.org
lgtm https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/EarlGreyiOS.json (right): https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/EarlGreyiOS.json:27: "app": "ios_chrome_reading_list_egtests", I think this test need some additional "args", doesn't it? We should ask +olivierrobin whether this is now working without "args" or not.
On 2016/12/20 00:52:52, smut wrote: > On 2016/12/20 00:50:03, rohitrao wrote: > > Only thing we have to watch for is capacity. +smut because we'll be adding > > additional load to the swarming bots. > > lgtm let's see what hit capacity takes. I suspect we need more because a lot > more stuff has been added lately. Oh this is upstream. I'm less concerned since we got a lot of capacity recently.
https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/EarlGreyiOS.json (right): https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/EarlGreyiOS.json:27: "app": "ios_chrome_reading_list_egtests", On 2016/12/20 00:53:25, sdefresne wrote: > I think this test need some additional "args", doesn't it? We should ask > +olivierrobin whether this is now working without "args" or not. Let's either match what we did downstream or remove it for now?
Removed the reading list suite. Thanks for the reviews! https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium... File ios/build/bots/chromium.fyi/EarlGreyiOS.json (right): https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium... ios/build/bots/chromium.fyi/EarlGreyiOS.json:27: "app": "ios_chrome_reading_list_egtests", On 2016/12/20 00:54:27, rohitrao wrote: > On 2016/12/20 00:53:25, sdefresne wrote: > > I think this test need some additional "args", doesn't it? We should ask > > +olivierrobin whether this is now working without "args" or not. > > Let's either match what we did downstream or remove it for now? Yup. Removed.
The CQ bit was checked by baxley@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rohitrao@chromium.org, smut@google.com, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2588193002/#ps40001 (title: "remove reading list")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482195402476320, "parent_rev": "3649039e8052104f429d25073f5089ec466206ba", "commit_rev": "b72ea9c624195448c0b851aa1cbf582085ac0a26"}
Message was sent while issue was closed.
Description was changed from ========== Run Chrome EarlGrey tests on FYI. Now that Chrome can be built upstream, we should run integration tests. BUG=675788 ========== to ========== Run Chrome EarlGrey tests on FYI. Now that Chrome can be built upstream, we should run integration tests. BUG=675788 Review-Url: https://codereview.chromium.org/2588193002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Run Chrome EarlGrey tests on FYI. Now that Chrome can be built upstream, we should run integration tests. BUG=675788 Review-Url: https://codereview.chromium.org/2588193002 ========== to ========== Run Chrome EarlGrey tests on FYI. Now that Chrome can be built upstream, we should run integration tests. BUG=675788 Committed: https://crrev.com/6c5381ffdf7c3b8efc3bb9b190bbb10d1d7f003d Cr-Commit-Position: refs/heads/master@{#439668} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6c5381ffdf7c3b8efc3bb9b190bbb10d1d7f003d Cr-Commit-Position: refs/heads/master@{#439668} |