Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 2588193002: Run Chrome EarlGrey tests on FYI. (Closed)

Created:
4 years ago by baxley
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run Chrome EarlGrey tests on FYI. Now that Chrome can be built upstream, we should run integration tests. BUG=675788 Committed: https://crrev.com/6c5381ffdf7c3b8efc3bb9b190bbb10d1d7f003d Cr-Commit-Position: refs/heads/master@{#439668}

Patch Set 1 #

Patch Set 2 : integration suite #

Total comments: 3

Patch Set 3 : remove reading list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M ios/build/bots/chromium.fyi/EarlGreyiOS.json View 1 2 2 chunks +61 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
baxley
4 years ago (2016-12-20 00:37:03 UTC) #2
rohitrao (ping after 24h)
lgtm FYI means we can make changes aggressively. Let's turn these on and see how ...
4 years ago (2016-12-20 00:49:26 UTC) #3
rohitrao (ping after 24h)
Only thing we have to watch for is capacity. +smut because we'll be adding additional ...
4 years ago (2016-12-20 00:50:03 UTC) #5
smut
On 2016/12/20 00:50:03, rohitrao wrote: > Only thing we have to watch for is capacity. ...
4 years ago (2016-12-20 00:52:52 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium.fyi/EarlGreyiOS.json File ios/build/bots/chromium.fyi/EarlGreyiOS.json (right): https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium.fyi/EarlGreyiOS.json#newcode27 ios/build/bots/chromium.fyi/EarlGreyiOS.json:27: "app": "ios_chrome_reading_list_egtests", I think this test need some ...
4 years ago (2016-12-20 00:53:25 UTC) #8
smut
On 2016/12/20 00:52:52, smut wrote: > On 2016/12/20 00:50:03, rohitrao wrote: > > Only thing ...
4 years ago (2016-12-20 00:54:16 UTC) #9
rohitrao (ping after 24h)
https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium.fyi/EarlGreyiOS.json File ios/build/bots/chromium.fyi/EarlGreyiOS.json (right): https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium.fyi/EarlGreyiOS.json#newcode27 ios/build/bots/chromium.fyi/EarlGreyiOS.json:27: "app": "ios_chrome_reading_list_egtests", On 2016/12/20 00:53:25, sdefresne wrote: > I ...
4 years ago (2016-12-20 00:54:27 UTC) #10
baxley
Removed the reading list suite. Thanks for the reviews! https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium.fyi/EarlGreyiOS.json File ios/build/bots/chromium.fyi/EarlGreyiOS.json (right): https://codereview.chromium.org/2588193002/diff/20001/ios/build/bots/chromium.fyi/EarlGreyiOS.json#newcode27 ios/build/bots/chromium.fyi/EarlGreyiOS.json:27: ...
4 years ago (2016-12-20 00:56:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588193002/40001
4 years ago (2016-12-20 00:56:59 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 02:12:50 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-20 02:15:33 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c5381ffdf7c3b8efc3bb9b190bbb10d1d7f003d
Cr-Commit-Position: refs/heads/master@{#439668}

Powered by Google App Engine
This is Rietveld 408576698