Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2588143002: Dashboard - Support build failures in bisect output. (Closed)

Created:
4 years ago by shatch
Modified:
4 years ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Dashboard - Support build failures in bisect output. Previously the recipe filtered the json data and the dashboard just outputted whatever was there. With this CL the dashboard will selectively print out build failures from the revision data depending on whether they're in the culprit range. Note: Not much of the output should change at first, only thing that should change is when we push the json data changes to prod you should see this for build failures: ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? 100 100 0 10 good 102 100 0 10 good 103 --- --- --- build failure 104 --- --- --- build failure 105 200 0 10 bad 106 200 0 10 bad Or in the case of lots and lots of failures: ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? 100 100 0 10 good 102 100 0 10 good 103 --- --- --- build failure --- --- --- --- too many build failures to list 114 --- --- --- build failure 115 200 0 10 bad 116 200 0 10 bad BUG=chromium:668540, chromium:665439 Review-Url: https://codereview.chromium.org/2588143002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/28346a164856545190e1f6c3b76ac6b1c354c82f

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -128 lines) Patch
M dashboard/dashboard/bisect_report.py View 1 chunk +63 lines, -11 lines 0 comments Download
M dashboard/dashboard/bisect_report_test.py View 1 14 chunks +369 lines, -117 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
shatch
4 years ago (2016-12-19 21:02:41 UTC) #4
sullivan
lgtm This is going to make things much easier to read!
4 years ago (2016-12-19 22:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588143002/40001
4 years ago (2016-12-20 18:14:22 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-20 18:32:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698