Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2588123002: Fix ODR violation in Blink (Closed)

Created:
4 years ago by altimin
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ODR violation in Blink Committed: https://crrev.com/b99683026286c7e6dcd33935c89bad4825a476c7 Cr-Commit-Position: refs/heads/master@{#439638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
altimin
PTAL
4 years ago (2016-12-19 19:11:41 UTC) #3
haraken
LGTM
4 years ago (2016-12-20 00:14:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588123002/1
4 years ago (2016-12-20 00:33:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:41:24 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 00:44:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b99683026286c7e6dcd33935c89bad4825a476c7
Cr-Commit-Position: refs/heads/master@{#439638}

Powered by Google App Engine
This is Rietveld 408576698