Rename blink::SelectorChecker::Match enum type to MatchStatus.

Rename blink::SelectorChecker::Match enum type to MatchStatus.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |Match| enum type
and a |match| method (differing by case of the first character); after a
naive rename by the rewrite_to_chrome_style tool we would end up with
|Match| being the name of both the type and the method (with both living
in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480
Committed: https://crrev.com/f045da4e3024621ab0fcbb336c2faf5fe9b244e7
Cr-Commit-Position: refs/heads/master@{#439646}

[Łukasz Anforowicz, 2016-12-19 22:56:34]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[Łukasz Anforowicz, 2016-12-19 22:56:57]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-19 22:56:57]

Daniel, can you PTAL?

[commit-bot: I haz the power, 2016-12-19 22:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:41:17]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-12-20 00:44:51]

LGTM

[Łukasz Anforowicz, 2016-12-20 01:00:23]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:00:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 01:05:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482195623169370, "parent_rev":
"95f7956e9a64e39bf968b3e6a5548b0d797f8373", "commit_rev":
"09a38a310ace43c3a35cef1f0ada9ff99b913f17"}

[commit-bot: I haz the power, 2016-12-20 01:06:14]

Description was changed from

==========
Rename blink::SelectorChecker::Match enum type to MatchStatus.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |Match| enum type
and a |match| method (differing by case of the first character); after a
naive rename by the rewrite_to_chrome_style tool we would end up with
|Match| being the name of both the type and the method (with both living
in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480
==========

to

==========
Rename blink::SelectorChecker::Match enum type to MatchStatus.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |Match| enum type
and a |match| method (differing by case of the first character); after a
naive rename by the rewrite_to_chrome_style tool we would end up with
|Match| being the name of both the type and the method (with both living
in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Review-Url: https://codereview.chromium.org/2588103003
==========

[commit-bot: I haz the power, 2016-12-20 01:06:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-20 01:09:15]

Description was changed from

==========
Rename blink::SelectorChecker::Match enum type to MatchStatus.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |Match| enum type
and a |match| method (differing by case of the first character); after a
naive rename by the rewrite_to_chrome_style tool we would end up with
|Match| being the name of both the type and the method (with both living
in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Review-Url: https://codereview.chromium.org/2588103003
==========

to

==========
Rename blink::SelectorChecker::Match enum type to MatchStatus.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an |Match| enum type
and a |match| method (differing by case of the first character); after a
naive rename by the rewrite_to_chrome_style tool we would end up with
|Match| being the name of both the type and the method (with both living
in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=673480

Committed: https://crrev.com/f045da4e3024621ab0fcbb336c2faf5fe9b244e7
Cr-Commit-Position: refs/heads/master@{#439646}
==========

[commit-bot: I haz the power, 2016-12-20 01:09:16]

Patchset 1 (id:??) landed as
https://crrev.com/f045da4e3024621ab0fcbb336c2faf5fe9b244e7
Cr-Commit-Position: refs/heads/master@{#439646}