Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2588103002: Simplify Image::isTextureBacked() (Closed)

Created:
4 years ago by f(malita)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, rwlbuis, fs, jbroman, Rik, f(malita), pdr+graphicswatchlist_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, ajuma+watch_chromium.org, danakj+watch_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Image::isTextureBacked() Only AcceleratedStaticBitmapImages can be texture backed, and they already override the method to return true. No need for a default baseclass impl beyond return false. Also constify. R=junov@chromium.org,ccameron@chromium.org Committed: https://crrev.com/e4211670b7c1c29f00c940b24ddc86f7f98c8372 Cr-Commit-Position: refs/heads/master@{#440797}

Patch Set 1 #

Patch Set 2 : redundant 'final' #

Patch Set 3 : unneeded UnacceleratedStaticBitmapImage override #

Patch Set 4 : rebase #

Messages

Total messages: 27 (19 generated)
f(malita)
4 years ago (2016-12-19 20:56:35 UTC) #12
ccameron
lgtm
4 years ago (2016-12-20 21:04:20 UTC) #13
Justin Novosad
LOL, of course! lgtm
4 years ago (2016-12-21 17:47:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588103002/40001
4 years ago (2016-12-22 19:08:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/127474) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-22 19:10:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588103002/60001
3 years, 12 months ago (2016-12-27 21:06:39 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 12 months ago (2016-12-27 22:29:10 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:33 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e4211670b7c1c29f00c940b24ddc86f7f98c8372
Cr-Commit-Position: refs/heads/master@{#440797}

Powered by Google App Engine
This is Rietveld 408576698