Import display: contents tests from csswg-test.

Import display: contents tests from csswg-test.

This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155

This should reduce the noise in https://codereview.chromium.org/2450093005, and
make it more manageable and straight-forward to review.

BUG=657748
Committed: https://crrev.com/6a8a116b565eee73ee54ec4a0dc476ce6f834c51
Cr-Commit-Position: refs/heads/master@{#439805}

[emilio, 2016-12-19 20:31:28]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 20:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:57:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[emilio, 2016-12-19 22:41:07]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 22:41:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 23:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 23:56:46]

Dry run: This issue passed the CQ dry run.

[emilio, 2016-12-20 07:31:32]

ecobos@igalia.com changed reviewers:
+ rego@igalia.com, rune@opera.com

[emilio, 2016-12-20 07:31:33]

Hi Rune, Rego,

Mind reviewing this?

This only does the obvious thing for the tests reviewed upstream so the diff
noise in my other CL can be reduced :)

Cheers:
Emilio

[Manuel Rego, 2016-12-20 08:16:34]

LGTM.

I'm wondering if it'd be better to mark display-contents-computed-style.html
as Failure in TestExpectations.
Instead of generating the -expected file with a "FAIL" line.

[tkent, 2016-12-20 08:18:25]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2016-12-20 08:18:25]

please read LayoutTests/imported/README.

[emilio, 2016-12-20 08:26:47]

On 2016/12/20 08:18:25, tkent wrote:
> please read LayoutTests/imported/README.

Hi tkent,

Could you elaborate? They won't be overwritten since they're already upstream,
but I wanted them in the tree soon-ish, and I don't know how often is the
auto-importer run. Is there any problem with checking-in this?

[emilio, 2016-12-20 08:27:49]

On 2016/12/20 08:26:47, emilio wrote:
> On 2016/12/20 08:18:25, tkent wrote:
> > please read LayoutTests/imported/README.
> 
> Hi tkent,
> 
> Could you elaborate? They won't be overwritten since they're already upstream,
> but I wanted them in the tree soon-ish, and I don't know how often is the
> auto-importer run. Is there any problem with checking-in this?

Concretely, these were imported using Tools/Scripts/import-w3c-tests -d
imported/csswg-test /path/to/csswg-test/css-display-3

[emilio, 2016-12-20 08:30:56]

I guess I can also do a full import, if that's required. Just let me know.

[tkent, 2016-12-20 08:30:59]

On 2016/12/20 at 08:27:49, ecobos wrote:
> On 2016/12/20 08:26:47, emilio wrote:
> > On 2016/12/20 08:18:25, tkent wrote:
> > > please read LayoutTests/imported/README.
> > 
> > Hi tkent,
> > 
> > Could you elaborate? They won't be overwritten since they're already
upstream,
> > but I wanted them in the tree soon-ish, and I don't know how often is the
> > auto-importer run. Is there any problem with checking-in this?
> 
> Concretely, these were imported using Tools/Scripts/import-w3c-tests -d
imported/csswg-test /path/to/csswg-test/css-display-3

We'll remove tests which are not listed in W3CImportExpectations.
You need to add

## Owners: ecobos@igalia.com
# imported/csswg-test/css-dislay-3 [ Pass ]

to W3CImportExpectations.

[emilio, 2016-12-20 08:51:41]

On 2016/12/20 08:30:59, tkent wrote:
> We'll remove tests which are not listed in W3CImportExpectations.
> You need to add
> 
> ## Owners: mailto:ecobos@igalia.com
> # imported/csswg-test/css-dislay-3 [ Pass ]
> 
> to W3CImportExpectations.

Oh, I see. I thought that file was only a blacklist, and saw that that directory
wasn't blacklisted (there were also pre-existing tests).

Added the entry though, thanks :)

[emilio, 2016-12-20 08:52:20]

The CQ bit was checked by ecobos@igalia.com

[emilio, 2016-12-20 08:52:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rego@igalia.com
Link to the patchset: https://codereview.chromium.org/2588093003/#ps40001
(title: "With explicit entry in W3CImportExpectations")

[commit-bot: I haz the power, 2016-12-20 08:52:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 09:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 09:58:05]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:2421
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
d8092bb2e3e2e3c5d01a11ad2aed40121b2e2d43..a3b06c2449b29e6024bac183b220a87faa4ec018
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -2421,3 +2421,36 @@ crbug.com/664859
virtual/threaded/transitions/transition-end-event-unprefixed-02
 crbug.com/664859 virtual/threaded/transitions/transition-end-event-window.html
[ Pass Failure ]
 crbug.com/664859 virtual/threaded/transitions/unprefixed-transform.html [ Pass
Failure ]
 # ====== Random order flaky tests end here ======
+
+# ====== Begin of display:contents tests ======
+
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-flex-001-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-flex-001-none.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-flex-002-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-flex-002-none.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-flex-003-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-flex-003-none.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-inline-flex-001-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-inline-flex-001-none.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-list-001-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-list-001-none.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-multicol-001-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-multicol-001-none.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-table-001-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-table-001-none.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-table-002-inline.html
[ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-dynamic-table-002-none.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-flex-001.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-flex-002.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-flex-003.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-float-001.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-inline-flex-001.html [
Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-list-001.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-multicol-001.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-oof-001.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-oof-002.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-table-001.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-table-002.html [ Failure ]
+crbug.com/657748
imported/csswg-test/css-display-3/display-contents-text-only-001.html [ Failure
]
+
+# ====== End of display: contents tests ======

[emilio, 2016-12-20 14:10:04]

The CQ bit was checked by ecobos@igalia.com

[emilio, 2016-12-20 14:10:05]

The patchset sent to the CQ was uploaded after l-g-t-m from rego@igalia.com
Link to the patchset: https://codereview.chromium.org/2588093003/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-20 14:10:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 15:13:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482243004575810,
"parent_rev": "654fa218959262e4f09459500969337ec9ea38eb", "commit_rev":
"43973d1fb56a83de27e054e26f01b3b9154628a9"}

[commit-bot: I haz the power, 2016-12-20 15:13:50]

Description was changed from

==========
Import display: contents tests from csswg-test.

This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155

This should reduce the noise in https://codereview.chromium.org/2450093005, and
make it more manageable and straight-forward to review.

BUG=657748
==========

to

==========
Import display: contents tests from csswg-test.

This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155

This should reduce the noise in https://codereview.chromium.org/2450093005, and
make it more manageable and straight-forward to review.

BUG=657748

Review-Url: https://codereview.chromium.org/2588093003
==========

[commit-bot: I haz the power, 2016-12-20 15:13:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-20 15:16:43]

Description was changed from

==========
Import display: contents tests from csswg-test.

This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155

This should reduce the noise in https://codereview.chromium.org/2450093005, and
make it more manageable and straight-forward to review.

BUG=657748

Review-Url: https://codereview.chromium.org/2588093003
==========

to

==========
Import display: contents tests from csswg-test.

This were reviewed upstream in https://github.com/w3c/csswg-test/pull/1155

This should reduce the noise in https://codereview.chromium.org/2450093005, and
make it more manageable and straight-forward to review.

BUG=657748

Committed: https://crrev.com/6a8a116b565eee73ee54ec4a0dc476ce6f834c51
Cr-Commit-Position: refs/heads/master@{#439805}
==========

[commit-bot: I haz the power, 2016-12-20 15:16:44]

Patchset 4 (id:??) landed as
https://crrev.com/6a8a116b565eee73ee54ec4a0dc476ce6f834c51
Cr-Commit-Position: refs/heads/master@{#439805}