Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2588003002: Fix GN bootstrap. (Closed)

Created:
4 years ago by saiarcot895
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap. Update list of required files and compile flags. BUG=None Committed: https://crrev.com/615f852746f6a8c1331eec32e8352d7cfcd63f76 Cr-Commit-Position: refs/heads/master@{#439509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
saiarcot895
4 years ago (2016-12-19 15:52:24 UTC) #2
Dirk Pranke
lgtm
4 years ago (2016-12-19 17:41:33 UTC) #4
saiarcot895
On 2016/12/19 at 17:41:33, dpranke wrote: > lgtm Do the tryjobs need to be run ...
4 years ago (2016-12-19 18:03:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588003002/1
4 years ago (2016-12-19 18:10:28 UTC) #9
brettw
The try bots don't technically need to run but I don't usually bother trying to ...
4 years ago (2016-12-19 18:10:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 18:35:45 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 18:38:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/615f852746f6a8c1331eec32e8352d7cfcd63f76
Cr-Commit-Position: refs/heads/master@{#439509}

Powered by Google App Engine
This is Rietveld 408576698