Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chromeos/dbus/auth_policy_client.h

Issue 2587993002: Chromad: Switch AuthPolicyClient to use cros_system_api enums. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/auth_policy_client.h
diff --git a/chromeos/dbus/auth_policy_client.h b/chromeos/dbus/auth_policy_client.h
index 1947b4a5d1d67a945d1abc0b374c8dd2c5b6df84..7680b518a56d46c767f89c17a8b3535bc418995c 100644
--- a/chromeos/dbus/auth_policy_client.h
+++ b/chromeos/dbus/auth_policy_client.h
@@ -10,18 +10,7 @@
#include "base/callback.h"
#include "chromeos/chromeos_export.h"
#include "chromeos/dbus/dbus_client.h"
-
-// TODO(rsorokin): Switch to service constants when it's landed.
-// (see crbug.com/659732)
-namespace authpolicy {
-namespace types {
-enum ADJoinErrorType {
- AD_JOIN_ERROR_NONE = 0,
- AD_JOIN_ERROR_UNKNOWN = 1,
- AD_JOIN_ERROR_DBUS_FAIL = 2,
-};
-} // namespace types
-} // namespace authpolicy
+#include "third_party/cros_system_api/dbus/service_constants.h"
namespace chromeos {
@@ -30,7 +19,8 @@ namespace chromeos {
// initializes the DBusThreadManager instance.
class CHROMEOS_EXPORT AuthPolicyClient : public DBusClient {
public:
Alexander Alekseev 2016/12/21 14:45:30 nit: please document here that error-code may be o
- using JoinCallback = base::Callback<void(int error_code)>;
+ using JoinCallback =
+ base::Callback<void(authpolicy::ADJoinErrorType error_code)>;
using RefreshPolicyCallback = base::Callback<void(bool success)>;
~AuthPolicyClient() override;

Powered by Google App Engine
This is Rietveld 408576698