Chromad: Switch AuthPolicyClient to use cros_system_api enums.

chromeos/dbus/auth_policy_client.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_AUTH_POLICY_CLIENT_H_
 #define CHROMEOS_DBUS_AUTH_POLICY_CLIENT_H_
 
 #include <string>
 
 #include "base/callback.h"
 #include "chromeos/chromeos_export.h"
 #include "chromeos/dbus/dbus_client.h"
-
-// TODO(rsorokin): Switch to service constants when it's landed.
-// (see crbug.com/659732)
-namespace authpolicy {
-namespace types {
-enum ADJoinErrorType {
-  AD_JOIN_ERROR_NONE = 0,
-  AD_JOIN_ERROR_UNKNOWN = 1,
-  AD_JOIN_ERROR_DBUS_FAIL = 2,
-};
-}  // namespace types
-}  // namespace authpolicy
+#include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
 // AuthPolicyClient is used to communicate with the org.chromium.AuthPolicy
 // sevice. All method should be called from the origin thread (UI thread) which
 // initializes the DBusThreadManager instance.
 class CHROMEOS_EXPORT AuthPolicyClient : public DBusClient {
  public:

[Alexander Alekseev, 2016/12/21 14:45:30]

nit: please document here that error-code may be outside of
authpolicy::ADJoinErrorType domain because this value actually comes from DBUS
integer value .

-  using JoinCallback = base::Callback<void(int error_code)>;
+  using JoinCallback =
+      base::Callback<void(authpolicy::ADJoinErrorType error_code)>;
   using RefreshPolicyCallback = base::Callback<void(bool success)>;
 
   ~AuthPolicyClient() override;
 
   // Factory function, creates a new instance and returns ownership.
   // For normal usage, access the singleton via DBusThreadManager::Get().
   static AuthPolicyClient* Create();
 
   // Calls JoinADDomain. It runs "net ads join ..." which joins machine to
   // Active directory domain.
@@ skipping 21 matching lines @@
   // Create() should be used instead.
   AuthPolicyClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AuthPolicyClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_AUTH_POLICY_CLIENT_H_