[CrOS Tether]: Add LocalDeviceDataProvider, which fetches device data for the local device.

[CrOS Tether]: Add LocalDeviceDataProvider, which fetches device data for the local device.

BUG=672263
Committed: https://crrev.com/0db25be78692cdd2f3e6b12f35d7014107676206
Cr-Commit-Position: refs/heads/master@{#439655}

[Kyle Horimoto, 2016-12-19 20:03:53]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org

[Ryan Hansberry, 2016-12-19 20:25:31]

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
File chromeos/components/tether/local_device_data_provider.h (right):

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
chromeos/components/tether/local_device_data_provider.h:46: class
LocalDeviceDataProviderContext {
In your HostScanScheduler CL, tengs@ preferred the name Delegate over Context
for a similar inner class. Does that same notion apply here?

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
File chromeos/components/tether/local_device_data_provider_unittest.cc (right):

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
chromeos/components/tether/local_device_data_provider_unittest.cc:127:
.WillByDefault(Return(fake_synced_devices_));
nit: make these stub calls a single helper method.

[Kyle Horimoto, 2016-12-19 21:23:55]

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
File chromeos/components/tether/local_device_data_provider.h (right):

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
chromeos/components/tether/local_device_data_provider.h:46: class
LocalDeviceDataProviderContext {
On 2016/12/19 20:25:31, Ryan Hansberry wrote:
> In your HostScanScheduler CL, tengs@ preferred the name Delegate over Context
> for a similar inner class. Does that same notion apply here?

Done.

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
File chromeos/components/tether/local_device_data_provider_unittest.cc (right):

https://codereview.chromium.org/2587963003/diff/1/chromeos/components/tether/...
chromeos/components/tether/local_device_data_provider_unittest.cc:127:
.WillByDefault(Return(fake_synced_devices_));
On 2016/12/19 20:25:31, Ryan Hansberry wrote:
> nit: make these stub calls a single helper method.

I'd like to keep them as-is to make the mocks as explicit as possible in each
case.

[Ryan Hansberry, 2016-12-19 21:30:03]

lgtm

[Kyle Horimoto, 2016-12-19 21:35:16]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:35:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:16:19]

Failed to apply patch for chromeos/components/tether/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: chromeos/components/tether/BUILD.gn:46
  error: chromeos/components/tether/BUILD.gn: patch does not apply

Patch:       chromeos/components/tether/BUILD.gn
Index: chromeos/components/tether/BUILD.gn
diff --git a/chromeos/components/tether/BUILD.gn
b/chromeos/components/tether/BUILD.gn
index
e4905284901d00d6ccc0c3e50f925adc48d8674b..3de4929d509b8cd865d89943b0064ee9fedbffb5
100644
--- a/chromeos/components/tether/BUILD.gn
+++ b/chromeos/components/tether/BUILD.gn
@@ -12,6 +12,8 @@ static_library("tether") {
     "host_scanner.h",
     "initializer.cc",
     "initializer.h",
+    "local_device_data_provider.cc",
+    "local_device_data_provider.h",
   ]
 
   deps = [
@@ -46,6 +48,7 @@ source_set("unit_tests") {
 
   sources = [
     "host_scan_scheduler_unittest.cc",
+    "local_device_data_provider_unittest.cc",
   ]
 
   deps = [

[Kyle Horimoto, 2016-12-20 00:22:05]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2016-12-20 00:22:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
hansberry@chromium.org
Link to the patchset: https://codereview.chromium.org/2587963003/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-12-20 00:22:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 01:29:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482193325572940,
"parent_rev": "5485a2fab0517e365a30cab0eea038f2dfc27902", "commit_rev":
"e79d57039482df069100cf65107ed5aa0d6a924e"}

[commit-bot: I haz the power, 2016-12-20 01:29:41]

Description was changed from

==========
[CrOS Tether]: Add LocalDeviceDataProvider, which fetches device data for the
local device.

BUG=672263
==========

to

==========
[CrOS Tether]: Add LocalDeviceDataProvider, which fetches device data for the
local device.

BUG=672263

Review-Url: https://codereview.chromium.org/2587963003
==========

[commit-bot: I haz the power, 2016-12-20 01:29:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 01:32:37]

Description was changed from

==========
[CrOS Tether]: Add LocalDeviceDataProvider, which fetches device data for the
local device.

BUG=672263

Review-Url: https://codereview.chromium.org/2587963003
==========

to

==========
[CrOS Tether]: Add LocalDeviceDataProvider, which fetches device data for the
local device.

BUG=672263

Committed: https://crrev.com/0db25be78692cdd2f3e6b12f35d7014107676206
Cr-Commit-Position: refs/heads/master@{#439655}
==========

[commit-bot: I haz the power, 2016-12-20 01:32:38]

Patchset 3 (id:??) landed as
https://crrev.com/0db25be78692cdd2f3e6b12f35d7014107676206
Cr-Commit-Position: refs/heads/master@{#439655}