Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2587943002: Fix a resource leak in insecure-websocket-in-secure-page-worker.html (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
falken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a resource leak in insecure-websocket-in-secure-page-worker.html This is a speculative fix for a leak reported by a leak bot. BUG=672740 Committed: https://crrev.com/fab77db556349d2f3c5cb893d5fba4f5f851799a Cr-Commit-Position: refs/heads/master@{#439696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
yhirano
I'll remove the LeakExpectation entries if this change fixes the leak.
4 years ago (2016-12-19 10:33:20 UTC) #5
falken
lgtm
4 years ago (2016-12-20 03:36:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587943002/1
4 years ago (2016-12-20 03:45:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 03:50:08 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 03:51:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fab77db556349d2f3c5cb893d5fba4f5f851799a
Cr-Commit-Position: refs/heads/master@{#439696}

Powered by Google App Engine
This is Rietveld 408576698