Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2587913005: [wasm] Freeze exports object (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Freeze exports object We were not conforming to the spec before. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2587913005 Cr-Commit-Position: refs/heads/master@{#41822} Committed: https://chromium.googlesource.com/v8/v8/+/5cbc4a96746adf14c419116da2fddab7642c2d82

Patch Set 1 #

Patch Set 2 : No IfDebug<T> type :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/wasm/wasm-module.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/add-getters.js View 2 chunks +8 lines, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Clemens Hammacher
4 years ago (2016-12-19 17:10:18 UTC) #10
titzer
lgtm
4 years ago (2016-12-19 17:17:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587913005/20001
4 years ago (2016-12-19 17:35:09 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-19 18:45:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5cbc4a96746adf14c419116da2fddab7642...

Powered by Google App Engine
This is Rietveld 408576698