Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2587913002: Rename activeDOMObjectsAreSuspended to isContextSuspended (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, mlamouri+watch-blink_chromium.org, blink-reviews-layout_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, timvolodine, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, nhiroki, jchaffraix+rendering, blink-reviews, kinuko+watch, tzik, kinuko+fileapi, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename activeDOMObjectsAreSuspended to isContextSuspended Since ActiveDOMObject was renamed to SuspendableObject. We should rename the method accordingly. BUG=610176 Committed: https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02 Cr-Commit-Position: refs/heads/master@{#440088}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -172 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/activedomobject/media.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/activedomobject/media-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html View 1 2 10 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release.html View 1 2 4 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release-noreference.html View 1 2 8 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html View 1 2 5 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SuspendableObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SuspendableObjectTest.cpp View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (13 generated)
haraken
PTAL
4 years ago (2016-12-19 08:30:04 UTC) #2
sof
lgtm. worth entertaining the idea of introducing isContextDestroyedOrSuspended() ?
4 years ago (2016-12-19 09:02:06 UTC) #3
haraken
> worth entertaining the idea of introducing isContextDestroyedOrSuspended() ? Yeah, agreed.
4 years ago (2016-12-19 09:27:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587913002/1
4 years ago (2016-12-19 09:27:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88607)
4 years ago (2016-12-19 10:27:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587913002/1
4 years ago (2016-12-21 08:32:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/126527) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-21 08:34:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587913002/20001
4 years ago (2016-12-21 08:40:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/353962)
4 years ago (2016-12-21 10:28:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587913002/40001
4 years ago (2016-12-21 11:41:39 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-21 14:18:46 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-21 14:21:16 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02
Cr-Commit-Position: refs/heads/master@{#440088}

Powered by Google App Engine
This is Rietveld 408576698